Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [M3-8662] - Update Github Actions actions #11009

Merged
merged 2 commits into from
Sep 26, 2024
Merged

chore: [M3-8662] - Update Github Actions actions #11009

merged 2 commits into from
Sep 26, 2024

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Sep 26, 2024 •
edited
Loading

Description 📝

  • Updates our Github Actions actions to resolve some depreciation warnings ⚠️
  • Makes a minor change to how we upload/download api-v4 and validation assets 📦
    • See comment below that explains this in more detail

Preview 📷

Before After
Screenshot 2024-09-25 at 8 32 01 PM Screenshot 2024-09-25 at 8 32 24 PM
ci.yml on develop ci.yml on this PR

How to test 🧪

  • Visually check the diff for errors 👀
  • Verify Github Actions on this PR pass ✅

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Sep 26, 2024
@bnussman-akamai bnussman-akamai self-assigned this Sep 26, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 26, 2024 00:16
@bnussman-akamai bnussman-akamai requested review from dwiley-akamai and abailly-akamai and removed request for a team September 26, 2024 00:16
bnussman-akamai
bnussman-akamai commented Sep 26, 2024
View reviewed changes
.github/workflows/ci.yml
Comment on lines -122 to -125
path: |
packages/api-v4/index.js
packages/api-v4/index.node.js
packages/api-v4/lib
Copy link
Member Author

@bnussman-akamai bnussman-akamai Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/api-v4/index.js and packages/api-v4/index.node.js have not existed since #8484 was merged ages ago. All of the build artifacts for validation and api-v4 are in the lib folder. This PR cleans up this to prevent confusion going forward

.github/workflows/ci.yml
Comment on lines -47 to -49
path: |
packages/validation/index.js
packages/validation/lib
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to the comment on the similar change for api-v4

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 86.98%
Current Coverage: 86.98%

abailly-akamai
abailly-akamai approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely 🧹 as well

Looks all good on my end

dwiley-akamai
dwiley-akamai approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything passes ✅
Code review ✅

.github/workflows/docs.yml
uses: actions/deploy-pages@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we miss a previous version jump for this and actions/configure-pages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. I'm guessing we may have built this Github Action from a guide somewhere online and maybe it didn't have the most up-to-date versions being used

@bnussman-akamai bnussman-akamai merged commit e17a038 into linode:develop Sep 26, 2024
20 checks passed
@cypress Cypress
Copy link

cypress bot commented Sep 26, 2024 •
edited
Loading

Cloud Manager E2E    Run #6581

Run Properties:  status check passed Passed #6581  •  git commit e17a038c8a: chore: [M3-8662] - Update Github Actions actions (#11009)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6581
Run duration 25m 56s
Commit git commit e17a038c8a: chore: [M3-8662] - Update Github Actions actions (#11009)
Committer Banks Nussman
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 408
View all changes introduced in this branch ↗︎

cpathipa pushed a commit to cpathipa/manager that referenced this pull request Sep 30, 2024
@bnussman-akamai @bnussman @cpathipa
chore: [M3-8662] - Update Github Actions actions (linode#11009)
b1e2a51 
* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
@bnussman-akamai bnussman-akamai mentioned this pull request Oct 1, 2024
Merged
12 tasks
This was referenced Oct 10, 2024
Merged
Merged
cpathipa added a commit that referenced this pull request Oct 15, 2024
@cpathipa @bnussman-akamai
@bnussman @mjac0bs
change: [M3-7887] - VPC Not Recommended Configuration Tooltip Text Re…
4fd4376 
…vision (#11098)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* chore: [M3-8662] - Update Github Actions actions (#11009)

* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>

* update revised copy

* Added changeset: VPC Not Recommended Configuration Tooltip Text Revision

* Update packages/manager/.changeset/pr-11098-changed-1728938497573.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Update packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
cpathipa added a commit that referenced this pull request Oct 17, 2024
@cpathipa @bnussman-akamai @bnussman
fix: [M3-7197] - "Support Ticket" button in network tab not working p…
d442759 
…roperly (#11074)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* chore: [M3-8662] - Update Github Actions actions (#11009)

* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>

* fix: [M3-7197] - "Support Ticket" button in network tab not working properly

* Create pr-11074-fixed-1728476792585.md

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
cpathipa added a commit that referenced this pull request Oct 17, 2024
@cpathipa @bnussman-akamai
@bnussman @mjac0bs
feat: [M3-7841] - Add the capability to search for a Linode by ID usi…
cf8823a 
…ng the main search tool. (#11112)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* chore: [M3-8662] - Update Github Actions actions (#11009)

* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>

* Add capability to search linode by id from main search tool

* Added changeset: Add the capability to search for a Linode by ID using the main search tool.

* Update packages/manager/.changeset/pr-11112-added-1729086990373.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Update packages/manager/cypress/e2e/core/linodes/search-linodes.spec.ts

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
cpathipa added a commit that referenced this pull request Oct 23, 2024
@cpathipa @bnussman-akamai @bnussman
refactor: [M3-8766] - Cleanup feature flag - Create Using Command Lin…
74d36a6 
…e (DX Tools Additions) (#11135)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* chore: [M3-8662] - Update Github Actions actions (#11009)

* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>

* Cleanup feature flag - apicliDxToolsAdditions

* Added changeset: Cleanup feature flag - Create Using Command Line (DX Tools Additions)

* PR - feedback - @coliu-akamai

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
cpathipa added a commit that referenced this pull request Oct 29, 2024
@cpathipa @bnussman-akamai @bnussman
refactor: [M3-8785] - Remove feature flag, tracking events used for A…
0818a7e 
…/B testing in API CLI tools Modal (#11156)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* chore: [M3-8662] - Update Github Actions actions (#11009)

* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>

* Remove feature flag, tracking events used for A/B testing in API CLI Tools Modal

* Added changeset: Remove feature flag, tracking events used for A/B testing in API CLI tools Modal

* PR feedback - @mjac0bs

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
cpathipa added a commit that referenced this pull request Dec 12, 2024
@cpathipa @bnussman-akamai
@bnussman @coliu-akamai
feat: [M3-8611]- New DatePicker Component (#11151)
518d85d 
* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* chore: [M3-8662] - Update Github Actions actions (#11009)

* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>

* Basci date picker component

* Test coverage for date picker component

* DatePicker Stories

* Custom DateTimePicker component

* Reusable TimeZone Select Component

* Create custom DateTimeRangePicker component

* Storybook for DateTimePicker

* Fix tests and remove console warnings

* changeset

* Update packages/manager/src/components/DatePicker/DateTimeRangePicker.tsx

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>

* Adjust styles for DatePicker

* Adjust styles for DateTimePicker

* update imports

* Render time and timezone conditionally in DateTimePicker component

* Move DatePicker to UI package

* Add DatePicker dependencies

* Code cleanup

* PR feedback

* code cleanup

* Move DatePicker back to src/components

* Reverting changes

* Code cleanup

* Adjust broken tests

* Update TimeZoneSelect.tsx

* Code cleanup

* Add validation for start date agains end date.

* Adjust styles for TimePicker component.

* PR feedback - @jaalah-akamai

* allow error messages from props.

* Update storybook components with args

* Update props

* PR feedback - @hana-akamai

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
cpathipa added a commit that referenced this pull request Jan 8, 2025
@cpathipa @bnussman-akamai
@bnussman @coliu-akamai @nikhagra-akamai
feat: [M3-8936] - Add Date Presets Functionality to Date Picker compo…
e97ff2f 
…nent. (#11395)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* chore: [M3-8662] - Update Github Actions actions (#11009)

* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>

* Basci date picker component

* Test coverage for date picker component

* DatePicker Stories

* Custom DateTimePicker component

* Reusable TimeZone Select Component

* Create custom DateTimeRangePicker component

* Storybook for DateTimePicker

* Fix tests and remove console warnings

* changeset

* Update packages/manager/src/components/DatePicker/DateTimeRangePicker.tsx

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>

* Adjust styles for DatePicker

* Adjust styles for DateTimePicker

* update imports

* Render time and timezone conditionally in DateTimePicker component

* Move DatePicker to UI package

* Add DatePicker dependencies

* Code cleanup

* PR feedback

* code cleanup

* Move DatePicker back to src/components

* Reverting changes

* Code cleanup

* Adjust broken tests

* Update TimeZoneSelect.tsx

* Code cleanup

* Add validation for start date agains end date.

* Adjust styles for TimePicker component.

* Add the functionality to support Date Presets

* Update presets functionality and add test coverage.

* Added changeset: Add Date Presets Functionality to Date Picker component

* Persist the preset value

* Show the start date and end date fields only when custom is selected

* Add calendar icon to DateTimePicker component

* code cleanup and adjust tests

* Update packages/manager/src/components/DatePicker/DateTimeRangePicker.tsx

Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com>

* update components

* Organize and additional prop support to DateTimeRangePicker component

* Code cleanup

* PR feedback - @coliu-akamai

* Move styles to theme level

* Revert "Move styles to theme level"

This reverts commit 15d9134.

* code cleanup

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com>
dmcintyr-akamai pushed a commit to dmcintyr-akamai/manager that referenced this pull request Jan 9, 2025
@cpathipa @bnussman-akamai
@bnussman @coliu-akamai @nikhagra-akamai @dmcintyr-akamai
feat: [M3-8936] - Add Date Presets Functionality to Date Picker compo…
012320a 
…nent. (linode#11395)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* chore: [M3-8662] - Update Github Actions actions (linode#11009)

* update actions

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>

* Basci date picker component

* Test coverage for date picker component

* DatePicker Stories

* Custom DateTimePicker component

* Reusable TimeZone Select Component

* Create custom DateTimeRangePicker component

* Storybook for DateTimePicker

* Fix tests and remove console warnings

* changeset

* Update packages/manager/src/components/DatePicker/DateTimeRangePicker.tsx

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>

* Adjust styles for DatePicker

* Adjust styles for DateTimePicker

* update imports

* Render time and timezone conditionally in DateTimePicker component

* Move DatePicker to UI package

* Add DatePicker dependencies

* Code cleanup

* PR feedback

* code cleanup

* Move DatePicker back to src/components

* Reverting changes

* Code cleanup

* Adjust broken tests

* Update TimeZoneSelect.tsx

* Code cleanup

* Add validation for start date agains end date.

* Adjust styles for TimePicker component.

* Add the functionality to support Date Presets

* Update presets functionality and add test coverage.

* Added changeset: Add Date Presets Functionality to Date Picker component

* Persist the preset value

* Show the start date and end date fields only when custom is selected

* Add calendar icon to DateTimePicker component

* code cleanup and adjust tests

* Update packages/manager/src/components/DatePicker/DateTimeRangePicker.tsx

Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com>

* update components

* Organize and additional prop support to DateTimeRangePicker component

* Code cleanup

* PR feedback - @coliu-akamai

* Move styles to theme level

* Revert "Move styles to theme level"

This reverts commit 15d9134.

* code cleanup

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

Assignees

@bnussman-akamai bnussman-akamai

Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @dwiley-akamai @abailly-akamai @bnussman