-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8541, M3-8621] - Unit tests for CollapsibleTable and CollapsibleRow components #11016
Merged
pmakode-akamai
merged 4 commits into
linode:develop
from
pmakode-akamai:M3-8541-8621-unit-tests-for-collapsibletable-and-collapsiblerow-components
Oct 3, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakode-akamai
requested review from
bnussman-akamai and
abailly-akamai
and removed request for
a team
September 30, 2024 11:05
pmakode-akamai
commented
Sep 30, 2024
packages/manager/src/components/CollapsibleTable/CollapsibleTable.stories.tsx
Outdated
Show resolved
Hide resolved
abailly-akamai
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the added coverage - this could/should easily be a cypress component test but this is helpful nonetheless.
Confirmed all new tests passing ✅
packages/manager/src/components/CollapsibleTable/CollapsibleTable.stories.tsx
Outdated
Show resolved
Hide resolved
bnussman-akamai
approved these changes
Oct 1, 2024
pmakode-akamai
force-pushed
the
M3-8541-8621-unit-tests-for-collapsibletable-and-collapsiblerow-components
branch
from
October 3, 2024 06:40
9e743ba
to
2c377f3
Compare
pmakode-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Ready for Review
labels
Oct 3, 2024
Coverage Report: ✅ |
Cloud Manager E2E Run #6614
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6614
|
Run duration | 29m 04s |
Commit |
c981cf4ccf: test: [M3-8541, M3-8621] - Unit tests for CollapsibleTable and CollapsibleRow co...
|
Committer | Purvesh Makode |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
4
|
Pending |
2
|
Skipped |
0
|
Passing |
409
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
stackscripts/create-stackscripts.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Create stackscripts > creates a StackScript with Any/All target image |
Screenshots
Video
|
images/machine-image-upload.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
machine image > uploads machine image, mock failed to decompress failed event |
Screenshots
Video
|
objectStorage/access-keys.smoke.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
object storage access keys smoke tests > can create access key - smoke |
Screenshots
Video
|
linodes/create-linode-with-vlan.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Create Linode with VLANs > can assign new VLANs during Linode create flow |
Screenshots
Video
|
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Unit test cases for CollapsibleTable and CollapsibleRow components.
Changes 🔄
Target release date 🗓️
N/A
How to test 🧪
Verification steps
yarn test CollapsibleTable --reporter verbose
As an Author I have considered 🤔
Check all that apply