feat: [UIE-8098] - DBaaS 2.0 Landing Page GA #11039

mpolotsk-akamai · 2024-10-02T16:01:33Z

Description 📝

DBaaS 2.0 Landing Page GA

Changes 🔄

List any change relevant to the reviewer.

Added Action Menu Column to the Databases Table
Updated Database Logo (removed Beta)

Note: The suspend action menu item will be added with the suspend feature in a separate PR.

Target release date 🗓️

10/14/24

Preview 📷

Before	After

How to test 🧪

Prerequisites

(How to setup test environment)
Note: For testing this change, ensure that DBaaS v2 is enabled, Beta is turned off, and the user has the "Managed Databases" account capability.

Verification steps

(How to verify changes)

Navigate to the Databases section.
The Databases table will display an additional Action Menu column.
Click on the Action Menu to reveal a dropdown with available actions.
From the Action Menu, the user can manage the database cluster, just like in the Settings tab.
Clicking Resize from the Action Menu will redirect you to the Resize tab.

As an Author I have considered 🤔

Check all that apply

github-actions · 2024-10-02T16:45:22Z

Coverage Report: ✅
Base Coverage: 86.97%
Current Coverage: 86.97%

bnussman-akamai · 2024-10-03T14:11:25Z

Looks like we have a failing unit test 👀

bnussman-akamai · 2024-10-03T14:20:20Z

packages/manager/src/features/Databases/DatabaseLanding/DatabaseActionMenu.tsx

  databaseLabel: string;
-  inlineLabel?: string;
+  handlers?: ActionHandlers;


Could we make handlers required in DatabaseRow and DatabaseActionMenu so we don't have to handle the undefined case?

bnussman-akamai · 2024-10-03T14:24:24Z

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx

+            allowList={allowList}
+            onClose={onCloseAccesControls}
+            open={isManageAccessControlsDialogOpen}
+            updateDatabase={updateDatabase}


Can we move the useDatabaseMutation / updateDatabase function into AddAccessControlDrawer so that it doesn't need to be a prop?

bnussman-akamai · 2024-10-03T14:27:35Z

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx

+    setIsManageAccessControlsDialogOpen,
+  ] = React.useState(false);
+
+  const [allowList, setAllowList] = React.useState<ExtendedIP[]>([]);


We shouldn't need to have allowList as state in this component. Can we just pass selectedDatabase to AddAccessControlDrawer and handle all of the state inside of AddAccessControlDrawer?

bnussman-akamai · 2024-10-03T14:28:42Z

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx

+          />
+        </>
+      ) : (
+        ''


Do we need this ''? Can we just use the following?

{isNewDatabase && (

cpathipa

Failed unit test in DatabaseLanding.test on this branch. left a few comments, other than that functionality LGTM! Agreed with Banks feedback.

packages/api-v4/.changeset/pr-11039-added-1727885059968.md

packages/manager/.changeset/pr-11039-upcoming-features-1727885138241.md

packages/manager/src/features/Databases/DatabaseLanding/DatabaseActionMenu.tsx

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLogo.tsx

cpathipa

@corya-akamai Thank you for addressing the feedback. I left a minor comment to remove a redundant undefined check, and there is a unit test failure that should be fixed. Other than that, the PR is good to go.

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLanding.tsx

packages/manager/src/features/Databases/DatabaseDetail/AddAccessControlDrawer.tsx

cpathipa

@corya-akamai Thank you for addressing all the feedback. Changes LGTM!

bnussman-akamai · 2024-10-08T15:07:40Z

There are some failing unit tests that need to be addressed

bnussman-akamai

I'm seeing a stray 0 and none of my databases are showing up 😰 when testing this PR against the dev API

corya-akamai · 2024-10-08T19:22:32Z

I'm seeing a stray 0 and none of my databases are showing up 😰 when testing this PR against the dev API

@bnussman-akamai Can you try now?

cpathipa · 2024-10-09T15:58:38Z

@corya-akamai There still a unit test failing in this one

bnussman-akamai · 2024-10-09T19:55:50Z

packages/manager/src/features/Databases/DatabaseLanding/DatabaseRow.tsx

+            databaseId={id}
+            databaseLabel={label}
+            handlers={handlers!}
+          ></DatabaseActionMenu>


Suggested change

></DatabaseActionMenu>

/>

bnussman-akamai · 2024-10-09T20:02:32Z

packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx

+          {selectedDatabase && (
+            <>
+              <DatabaseSettingsDeleteClusterDialog
+                databaseEngine={selectedDatabase.engine}
+                databaseID={selectedDatabase.id}
+                databaseLabel={selectedDatabase?.label}
+                onClose={() => setIsDeleteDialogOpen(false)}
+                open={isDeleteDialogOpen}
+              />
+              <DatabaseSettingsResetPasswordDialog
+                databaseEngine={selectedDatabase.engine}
+                databaseID={selectedDatabase.id}
+                onClose={() => setIsResetPasswordsDialogOpen(false)}
+                open={isResetPasswordsDialogOpen}
+              />
+              <AddAccessControlDrawer
+                database={selectedDatabase}
+                onClose={onCloseAccesControls}
+                open={isManageAccessControlsDialogOpen}
+              />
+            </>
+          )}
+        </>
+      )}


Because we are conditionally rendering these dialogs/drawers. The open/close animation is broken. It is noticeable on AddAccessControlDrawer. We should consider keeping them rendered at all times. This is usually how we keep the animation working.

Good catch @bnussman-akamai I'll address it. There also seems to be an issue with sorting that needs to be addressed before merging.

@bnussman-akamai I updated so the animation is working. The sorting is not workin for the "new" tab but that is a backend issue they are working on..

mjac0bs · 2024-10-10T17:57:45Z

Test failures in CI were unrelated (Cypress failures on delete placement group spec and vpc landing page) and component test failures due to memory issues. Unit tests pass now. Going to merge.

cypress · 2024-10-10T18:31:53Z

Cloud Manager E2E Run #6658

Run Properties: Failed #6658 • c8f33a73e3: feat: [UIE-8098] - DBaaS GA Landing Page (#11039)

Project	`Cloud Manager E2E`
Run status	`Failed #6658`
Run duration	`31m 27s`
Commit	`c8f33a73e3: feat: [UIE-8098] - DBaaS GA Landing Page (#11039)`
Committer	`mpolotsk-akamai`
View all properties for this run ↗︎

Test results
Failures	`3`
Flaky	`4`
Pending	`2`
Skipped	`0`
Passing	`428`

Tests for review

linodes/clone-linode.spec.ts • 1 failed test

View Output Video

Test		Artifacts
clone linode > can clone a Linode from Linode details page		`Screenshots` `Video`

linodes/rebuild-linode.spec.ts • 1 failed test

View Output Video

Test		Artifacts
rebuild linode > cannot rebuild a provisioning linode		`Screenshots` `Video`

placementGroups/delete-placement-groups.spec.ts • 1 failed test

View Output Video

Test		Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry		`Screenshots` `Video`

placementGroups/delete-placement-groups.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Placement Group deletion > can unassign Linode when unexpected error show up and reopen the dialog		`Screenshots` `Video`

linodes/backup-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
linode backups > can capture a manual snapshot		`Screenshots` `Video`

domains/smoke-clone-domain.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Clone a Domain > clones a domain		`Screenshots` `Video`

volumes/create-volume.smoke.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
volumes > does not allow creation of a volume with invalid pricing from volumes landing		`Screenshots` `Video`

mpolotsk-akamai requested a review from a team as a code owner October 2, 2024 16:01

mpolotsk-akamai requested review from bnussman-akamai and hkhalil-akamai and removed request for a team October 2, 2024 16:01

mpolotsk-akamai force-pushed the feature/UIE-8098-DBaaS-GA-Landing-Page branch from 8aca711 to 13e8624 Compare October 2, 2024 16:17

cpathipa requested review from cpathipa and removed request for hkhalil-akamai October 2, 2024 18:26

mpolotsk-akamai force-pushed the feature/UIE-8098-DBaaS-GA-Landing-Page branch from 13e8624 to 6f653bc Compare October 2, 2024 18:48

coliu-akamai assigned mpolotsk-akamai Oct 2, 2024

coliu-akamai added the DBaaS Relates to Database as a Service label Oct 2, 2024

bnussman-akamai reviewed Oct 3, 2024

View reviewed changes

cpathipa reviewed Oct 3, 2024

View reviewed changes

corya-akamai force-pushed the feature/UIE-8098-DBaaS-GA-Landing-Page branch 3 times, most recently from d15f7b8 to d8e1227 Compare October 7, 2024 19:15

cpathipa requested changes Oct 7, 2024

View reviewed changes

cpathipa requested a review from bnussman-akamai October 7, 2024 19:48

corya-akamai force-pushed the feature/UIE-8098-DBaaS-GA-Landing-Page branch 2 times, most recently from 85ca6e2 to 2c689e4 Compare October 7, 2024 20:46

corya-akamai requested a review from cpathipa October 7, 2024 21:20

cpathipa approved these changes Oct 8, 2024

View reviewed changes

cpathipa added the Add'tl Approval Needed Waiting on another approval! label Oct 8, 2024

bnussman-akamai reviewed Oct 8, 2024

View reviewed changes

corya-akamai force-pushed the feature/UIE-8098-DBaaS-GA-Landing-Page branch from 2c689e4 to 0ed20a3 Compare October 8, 2024 18:58

corya-akamai requested a review from bnussman-akamai October 8, 2024 19:22

corya-akamai force-pushed the feature/UIE-8098-DBaaS-GA-Landing-Page branch from 0ed20a3 to d950776 Compare October 9, 2024 18:35

bnussman-akamai approved these changes Oct 9, 2024

View reviewed changes

bnussman-akamai reviewed Oct 9, 2024

View reviewed changes

bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 9, 2024

corya-akamai force-pushed the feature/UIE-8098-DBaaS-GA-Landing-Page branch 4 times, most recently from a1e82b8 to 0ec2684 Compare October 10, 2024 14:25

feat: [UIE-8098] - DBaaS GA Landing Page

a42fa99

corya-akamai force-pushed the feature/UIE-8098-DBaaS-GA-Landing-Page branch from 0ec2684 to a42fa99 Compare October 10, 2024 14:58

mjac0bs merged commit c8f33a7 into linode:develop Oct 10, 2024
21 of 23 checks passed

This was referenced Oct 10, 2024

Release v1.130.0 - release → staging #11087

Merged

Release v1.130.0- staging → master #11095

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [UIE-8098] - DBaaS 2.0 Landing Page GA #11039

feat: [UIE-8098] - DBaaS 2.0 Landing Page GA #11039

mpolotsk-akamai commented Oct 2, 2024

github-actions bot commented Oct 2, 2024 •

edited

Loading

bnussman-akamai commented Oct 3, 2024

bnussman-akamai Oct 3, 2024

corya-akamai Oct 7, 2024

bnussman-akamai Oct 3, 2024

corya-akamai Oct 7, 2024

bnussman-akamai Oct 3, 2024

corya-akamai Oct 7, 2024

bnussman-akamai Oct 3, 2024

corya-akamai Oct 7, 2024

cpathipa left a comment

cpathipa left a comment

cpathipa left a comment

bnussman-akamai commented Oct 8, 2024

bnussman-akamai left a comment

corya-akamai commented Oct 8, 2024

cpathipa commented Oct 9, 2024

bnussman-akamai Oct 9, 2024

corya-akamai Oct 10, 2024

bnussman-akamai Oct 9, 2024

corya-akamai Oct 9, 2024

corya-akamai Oct 10, 2024

mjac0bs commented Oct 10, 2024

cypress bot commented Oct 10, 2024

feat: [UIE-8098] - DBaaS 2.0 Landing Page GA #11039

feat: [UIE-8098] - DBaaS 2.0 Landing Page GA #11039

Conversation

mpolotsk-akamai commented Oct 2, 2024

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

github-actions bot commented Oct 2, 2024 • edited Loading

bnussman-akamai commented Oct 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpathipa left a comment

Choose a reason for hiding this comment

cpathipa left a comment

Choose a reason for hiding this comment

cpathipa left a comment

Choose a reason for hiding this comment

bnussman-akamai commented Oct 8, 2024

bnussman-akamai left a comment

Choose a reason for hiding this comment

corya-akamai commented Oct 8, 2024

cpathipa commented Oct 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjac0bs commented Oct 10, 2024

cypress bot commented Oct 10, 2024

Tests for review

github-actions bot commented Oct 2, 2024 •

edited

Loading