Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [M3-8700] - Rename Linode Create v2 to Linode Create #11043

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Oct 3, 2024

Description 📝

This PR finishes the Linode Create Reactor ✨ by renaming Linode Linode Create v2 to Linode Create ✏️ It's been a long time coming, but we made it happen 🥲🎉

Preview 📷

Note

There should not be any UI changes. This PR just updates file names and component names for organizational purposes 🗄️

How to test 🧪

  • Verify Linode Create still works as expected
  • Verify unit tests pass
  • Verify cypress tests pass

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai marked this pull request as ready for review October 3, 2024 17:36
@bnussman-akamai bnussman-akamai requested review from a team as code owners October 3, 2024 17:36
@bnussman-akamai bnussman-akamai requested review from cliu-akamai, carrillo-erik and hkhalil-akamai and removed request for a team October 3, 2024 17:36
Copy link

github-actions bot commented Oct 3, 2024

Coverage Report:
Base Coverage: 87.19%
Current Coverage: 87.19%

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @bnussman-akamai and congratulations! Glad to finally put Create v1 behind us. 🎉

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work, thanks Banks! 🎉

there's one last reference to LinodesCreatev2, in src/features/Linodes/index.tsx but other than that looks good!

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Oct 3, 2024
@bnussman-akamai bnussman-akamai merged commit 2aeea52 into linode:develop Oct 4, 2024
20 checks passed
Copy link

cypress bot commented Oct 4, 2024

Cloud Manager E2E    Run #6622

Run Properties:  status check passed Passed #6622  •  git commit 2aeea52dfb: chore: [M3-8700] - Rename `Linode Create v2` to `Linode Create` (#11043)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6622
Run duration 27m 33s
Commit git commit 2aeea52dfb: chore: [M3-8700] - Rename `Linode Create v2` to `Linode Create` (#11043)
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 414
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Linode Create Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants