Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8436] - Add cypress test for create validation & API errors for OBJ Gen 2 #11066

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Oct 8, 2024

Description 📝

Adds a test to confirm creation and validation errors for OBJ Gen 2

How to test 🧪

  • yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai marked this pull request as ready for review October 8, 2024 15:12
@coliu-akamai coliu-akamai requested review from a team as code owners October 8, 2024 15:12
@coliu-akamai coliu-akamai requested review from AzureLatte, carrillo-erik and abailly-akamai and removed request for a team October 8, 2024 15:12
@coliu-akamai coliu-akamai changed the title test: [M3-8436] - Add test for create validation & API errors for OBJ Gen 2 Cypress test: [M3-8436] - Add cypress test for create validation & API errors for OBJ Gen 2 Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Coverage Report:
Base Coverage: 86.95%
Current Coverage: 86.95%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding coverage!

  • Code looks good on my end and test passes ✅
  • e2e failure in CI is unrelated ✅

@@ -165,7 +165,7 @@ export const OMC_CreateBucketDrawer = (props: Props) => {
// since this is optional in the schema.
if (Boolean(endpoints) && !formValues.endpoint_type) {
setError('endpoint_type', {
message: 'Endpoint Type is required',
message: 'Endpoint Type is required.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great attention to detail by adding the period (.) here.

Copy link
Contributor

@carrillo-erik carrillo-erik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirms that running this PR locally works as expected ✅.

@coliu-akamai coliu-akamai merged commit b7d58b9 into linode:develop Oct 10, 2024
19 of 20 checks passed
Copy link

cypress bot commented Oct 10, 2024

Cloud Manager E2E    Run #6657

Run Properties:  status check passed Passed #6657  •  git commit b7d58b90f5: test: [M3-8436] - Add cypress test for create validation & API errors for OBJ Ge...
Project Cloud Manager E2E
Run status status check passed Passed #6657
Run duration 28m 22s
Commit git commit b7d58b90f5: test: [M3-8436] - Add cypress test for create validation & API errors for OBJ Ge...
Committer Connie Liu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 8
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants