-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8436] - Add cypress test for create validation & API errors for OBJ Gen 2 #11066
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding coverage!
- Code looks good on my end and test passes ✅
- e2e failure in CI is unrelated ✅
@@ -165,7 +165,7 @@ export const OMC_CreateBucketDrawer = (props: Props) => { | |||
// since this is optional in the schema. | |||
if (Boolean(endpoints) && !formValues.endpoint_type) { | |||
setError('endpoint_type', { | |||
message: 'Endpoint Type is required', | |||
message: 'Endpoint Type is required.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great attention to detail by adding the period (.)
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirms that running this PR locally works as expected ✅.
Cloud Manager E2E Run #6657
Run Properties:
|
Project |
Cloud Manager E2E
|
Run status |
Passed #6657
|
Run duration | 28m 22s |
Commit |
b7d58b90f5: test: [M3-8436] - Add cypress test for create validation & API errors for OBJ Ge...
|
Committer | Connie Liu |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
8
|
Pending |
2
|
Skipped |
0
|
Passing |
431
|
Description 📝
Adds a test to confirm creation and validation errors for OBJ Gen 2
How to test 🧪
As an Author I have considered 🤔
Check all that apply