feat: [M3-8560] - NodeBalancer Configurations - Support Linodes with Multiple Private IPs #11069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
hkhalil-akamai and
jaalah-akamai
and removed request for
a team
bnussman-akamai
commented
Oct 9, 2024
There was a problem hiding this comment.
The primary changes are here 🚨
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
Oct 9, 2024
packages/manager/src/features/Linodes/LinodesLanding/IPAddress.tsx
Outdated
Show resolved
Hide resolved
Yes, this is expected! |
jaalah-akamai
approved these changes
Oct 10, 2024
| @@ -3,6 +3,8 @@ import { array, boolean, mixed, number, object, string } from 'yup'; | |||
| const PORT_WARNING = 'Port must be between 1 and 65535.'; | |||
| const LABEL_WARNING = 'Label must be between 3 and 32 characters.'; | |||
|
|
|||
| export const PRIVATE_IPv4_REGEX = /^10\.|^172\.1[6-9]\.|^172\.2[0-9]\.|^172\.3[0-1]\.|^192\.168\.|^fd/; | |||
|
|
|||
There was a problem hiding this comment.
Much better place for this 🔥
| value={options.find((o) => o.label === nodeAddress) ?? null} | ||
| /> | ||
| ); | ||
| }); |
Cloud Manager E2E
|
||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Run status |
|
| Run duration | 28m 36s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
435
|
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
test-1test-1How to test 🧪
Prerequisites
Verification steps
Note
We surface all Private IPs for each Linode but you may run into an API validation error when choosing the
172.address. This should be fine because the DevCloud team requested we show both options (even though the API may reject one of then)As an Author I have considered 🤔