fix: TypeScript performance of DismissibleBanner.tsx
#11075
Conversation
bnussman-akamai
requested review from
hkhalil-akamai and
jaalah-akamai
and removed request for
a team
| /** | ||
| * Additional styles to apply to the root element | ||
| */ | ||
| sx?: SxProps; |
There was a problem hiding this comment.
There is no need to specify these props because they exist on the interface that this extends (NoticeProps in this case)
There was a problem hiding this comment.
Also another random thought, but I wonder if sx could be slow. I assume it is a very heavy type. Wondering if SxProps<Theme> is any better or worse
| } | ||
|
|
||
| interface DismissibleBannerProps | ||
| extends Omit<Partial<NoticeProps>, 'children'>, |
There was a problem hiding this comment.
I'm wondering if Partial<NoticeProps> might be of interest.
BarPercent.tsx has something similar and it takes 17 seconds to type-check
There was a problem hiding this comment.
most likely. those used to be types unions I believe, and I remember working on those and may have messed that up trying to actually improve the performance doing an interface inheritance. I will certainly profile more often
|
Amazing 🥇 |
|
Coverage Report: ✅ |
| @@ -1,31 +1,20 @@ | |||
| import Close from '@mui/icons-material/Close'; | |||
| import Grid from '@mui/material/Unstable_Grid2'; | |||
| import { SxProps } from '@mui/system'; | |||
There was a problem hiding this comment.
Starting to wonder if importing from @mui/system rather than @mui/material is a main source of the slowness.
Maybe I should hurry up with pnpm. I'm 99.9% will prevent @mui/system imports by nature...
Cloud Manager E2E
|
||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Run status |
|
| Run duration | 27m 25s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
430
|
Description 📝
DismissibleBanner.tsx's TypeScript types in hopes to improvetscperformance 🧼Preview 📷
Running
tscgot 14 seconds fasterProfile shows that
DismissibleBanner.tsxtype checks much fasterHow to test 🧪
yarn tsc --generateTrace ./trace --incremental falseand inspect withchrome://tracing)As an Author I have considered 🤔