Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [M3-8705] - Disable Create Longview Client button with tooltip text on Landing Page for restricted Users. #11108

Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat: [M3-8705] - Disable Create Longview Client button with tooltip text on Landing Page for restricted Users. #11108

merged 3 commits into from
Oct 21, 2024

Conversation

hasyed-akamai
Copy link
Contributor

Description 📝

To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.

Here, we are restricting users from creating new Longview Client on the Landing Page when they do not have access

Changes 🔄

List any change relevant to the reviewer.

  • For restricted users:
    • Disabled Create Longview Clients Button on the Landing Page

Target release date 🗓️

Preview 📷

Before After
Before After

How to test 🧪

Prerequisites

  • Log into two accounts side by side:
    • An unrestricted admin user account: full access
    • A restricted user account (use Incognito for this)

Reproduction steps

  • Landing:
    • Observe as restricted user, notice shows and you cannot create Clients

Verification steps

  • After changes, observe tooltips are tailored to the action.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai requested a review from a team as a code owner October 16, 2024 06:17
@hasyed-akamai hasyed-akamai requested review from carrillo-erik and jaalah-akamai and removed request for a team October 16, 2024 06:17
@hasyed-akamai hasyed-akamai self-assigned this Oct 16, 2024
@hasyed-akamai hasyed-akamai added Ready for Review Restricted User Access Improve UX surrounding restricted access to features labels Oct 16, 2024
pmakode-akamai
pmakode-akamai approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

packages/manager/.changeset/pr-11108-changed-1729059614823.md Outdated Show resolved Hide resolved
@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 16, 2024
@hasyed-akamai @pmakode-akamai
change changeset description
e5e9fa5 
Co-authored-by: Purvesh Makode <pmakode@akamai.com>
coliu-akamai
coliu-akamai approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed Add Client button is disabled for restricted account + tooltip
✅ confirmed it's not disabled for a non-restricted account

Thanks Haneef! 🎉

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Oct 17, 2024
@pmakode-akamai pmakode-akamai merged commit 17d0883 into linode:develop Oct 21, 2024
21 of 23 checks passed
@cypress Cypress
Copy link

cypress bot commented Oct 21, 2024

Cloud Manager E2E    Run #6701

Run Properties:  status check passed Passed #6701  •  git commit 17d0883291: feat: [M3-8705] - Disable Create Longview Client button with tooltip text on Lan...
Project Cloud Manager E2E
Run status status check passed Passed #6701
Run duration 26m 06s
Commit git commit 17d0883291: feat: [M3-8705] - Disable Create Longview Client button with tooltip text on Lan...
Committer hasyed-akamai
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438

This was referenced Oct 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmakode-akamai pmakode-akamai pmakode-akamai approved these changes

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@carrillo-erik carrillo-erik Awaiting requested review from carrillo-erik carrillo-erik is a code owner automatically assigned from linode/frontend

@jaalah-akamai jaalah-akamai Awaiting requested review from jaalah-akamai jaalah-akamai is a code owner automatically assigned from linode/frontend

Assignees

@hasyed-akamai hasyed-akamai

Labels
Approved Multiple approvals and ready to merge! Restricted User Access Improve UX surrounding restricted access to features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasyed-akamai @coliu-akamai @pmakode-akamai