Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8763] - fix flaky DatabaseBackups.test.tsx in coverage job #11130

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Oct 21, 2024

Description 📝

Attempting to fix an annoyance with this test only failing on the coverage:summary job in the CI, resulting a failing step. While this is non blocking, it prevents the coverage job from running and therefore update our score.

It is hard to pinpoint when this started happening, but every PR is experiencing this issue so it needs to be fixed.
I am forcing the current_branch to run, so we can still see if yarn coverage:summary actually passes without issues on the current branch in case base_branch is flaky

Changes 🔄

  • Improve DatabaseBackups.test.tsx test
  • force current_branch coverage step to run

How to test 🧪

Verification steps

Locally

  • run yarn test DatabaseBackups.test.tsx and verify it passes
  • run yarn coverage:summary confirmed no flakes/passes 100%

CI

  • confirm coverage > base_branch > Run Current Branch Coverage succeeds
  • confirm coverage > current_branch > Run Current Branch Coverage succeeds

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Oct 21, 2024
@abailly-akamai abailly-akamai requested a review from a team as a code owner October 21, 2024 18:51
@abailly-akamai abailly-akamai requested review from mjac0bs and bnussman-akamai and removed request for a team October 21, 2024 18:51
Copy link

github-actions bot commented Oct 21, 2024

Coverage Report:
Base Coverage: 87.05%
Current Coverage: 87.05%

@bnussman-akamai bnussman-akamai changed the title fix: [M3-8763] fix flaky DatabaseBackups.test.tsx in coverage job fix: [M3-8763] - fix flaky DatabaseBackups.test.tsx in coverage job Oct 21, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not observe flake locally or in CI and looked good other than my one docs comment.

.github/workflows/coverage.yml Outdated Show resolved Hide resolved
@abailly-akamai
Copy link
Contributor Author

cool, current_branch job is passing consistently, good to merge

@abailly-akamai abailly-akamai merged commit 7dc8c8b into linode:develop Oct 21, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants