change: [UIE-8220] - Settings text update #11166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smans-akamai
requested review from
bnussman-akamai and
jaalah-akamai
and removed request for
a team
smans-akamai
force-pushed
the
UIE-8204-dbaas-settings-text-update
branch
from
d76c819 to
b1ebdde
Compare
|
@smans-akamai Heads up you still have failing units as a result of this PR |
cpathipa
requested review from
cpathipa
and removed request for
bnussman-akamai
mjac0bs
reviewed
Oct 28, 2024
There was a problem hiding this comment.
The things I mention below aren't included in this PR, but they are text on the Settings page so it may make sense to address them in this PR.
Couple questions about Weekly Maintenance Window copy:
- Can we add a space before the sentence that starts
For non-HA plansafter the period of the preceding sentence? - Is the DBaaS team intentionally using the term
DB Enginehere? Throughout the rest of Cloud Manager, I believe we spell outdatabaserather than useDB, so I'm curious to know if this is changing or if we want to continue without the abbreviation for consistency?
mpolotsk-akamai
force-pushed
the
UIE-8204-dbaas-settings-text-update
branch
from
595a1cc to
55fcfd5
Compare
|
Coverage Report: ✅ |
mjac0bs
reviewed
Oct 30, 2024
There was a problem hiding this comment.
I'm seeing test failures in CI that seem relevant. Unit test updates look good, but you'll want to run
yarn cy:run -s "cypress/e2e/core/databases/update-database.spec.ts,cypress/e2e/core/databases/resize-database.spec.ts"
and make sure the labels are updated.
| @@ -198,7 +198,7 @@ export const MaintenanceWindow = (props: Props) => { | |||
| <Typography className={classes.sectionText}> | |||
| {isLegacy ? typographyLegacyDatabase : typographyDatabase} | |||
| {database.cluster_size !== 3 | |||
| ? 'For non-HA plans, expect downtime during this window.' | |||
| ? ' For non-HA plans, expect downtime during this window.' | |||
There was a problem hiding this comment.
Suggested change
| ? ' For non-HA plans, expect downtime during this window.' | |
| {isLegacy ? typographyLegacyDatabase : typographyDatabase}{' '} | |
| {database.cluster_size !== 3 | |
| ? 'For non-HA plans, expect downtime during this window.' | |
| : null} |
Nit: how we tend to add spaces to avoid modifying the actual copy.
cpathipa
reviewed
Oct 30, 2024
|
Okay, it was just the update spec that is relevant here. Looks like the resize spec was due to a feature flag toggle as Joe mentions here: #11190 |
mpolotsk-akamai
requested review from
jdamore-linode
and removed request for
a team
mpolotsk-akamai
force-pushed
the
UIE-8204-dbaas-settings-text-update
branch
from
df23346 to
bf4d30f
Compare
cpathipa
approved these changes
Oct 31, 2024
jdamore-linode
approved these changes
Oct 31, 2024
mjac0bs
approved these changes
Oct 31, 2024
mjac0bs
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 24m 59s |
| Commit |
|
| Committer | smans-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Updating text for database settings
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
11/12/2024
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
As an Author I have considered 🤔