upcoming: [M3-8772] - Add global borderRadiusTokens to theme and replace hardcoded values #11169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
…harcoded values where borderRadius = 0
Cloud Manager UI test results🎉 445 passing tests on test run #4 ↗︎
|
zaenab-akamai
requested review from
hana-akamai,
carrillo-erik and
jaalah-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Nov 4, 2024
hana-akamai
reviewed
Nov 4, 2024
| borderRadius: 0, | ||
| borderRadius: theme.tokens.borderRadius.None, |
There was a problem hiding this comment.
Personally, I think it's easier just to type 0 than theme.tokens.borderRadius.None
There was a problem hiding this comment.
I agree it's shorter, but what tokens provide is essentially semantic clarity and intent. Often you'll hear alias tokens be referred to as semantic tokens in that using the token makes it clear this was an intentional design decision rather than a one-off value. So granted None will always mean 0 in this case, there's other benefits we obtain from this approach as well
jaalah-akamai
approved these changes
Nov 4, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 27s |
| Commit |
|
| Committer | zaenab-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add global (theme agnostic) border radius tokens to
themeChanges 🔄
themeaccessible viatheme.tokens.borderRadiusas mentioned in this PRTarget release date 🗓️
NA
Preview 📷
NA
How to test 🧪
theme.tokens.*As an Author I have considered 🤔
Check all that apply