Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UIE-8007] - DBaaS display host in summary details #11182

Merged

Conversation

corya-akamai
Copy link
Contributor

@corya-akamai corya-akamai commented Oct 29, 2024

Description 📝

Fix the display of host in DBaaS summary details

Changes 🔄

List any change relevant to the reviewer.

  • Remove MongoDB related code as it is no longer supported
  • Correctly show primary host in details

Target release date 🗓️

11/12/24

Preview 📷

Before After
alpha fix

How to test 🧪

Prerequisites

  • Managed Databases Beta capability
  • dbaasV2 feature flag

Reproduction steps

  • Navigate to database summary details page

Verification steps

  • Host is displayed

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@corya-akamai corya-akamai requested a review from a team as a code owner October 29, 2024 14:31
@corya-akamai corya-akamai requested review from cpathipa and coliu-akamai and removed request for a team October 29, 2024 14:31
@corya-akamai corya-akamai force-pushed the UIE-8007-dbaas-fix-display-host branch from 1ddea47 to 2127083 Compare October 29, 2024 14:32
@cpathipa cpathipa added the DBaaS Relates to Database as a Service label Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

Coverage Report:
Base Coverage: 86.99%
Current Coverage: 86.99%

@bnussman-akamai bnussman-akamai changed the base branch from develop to staging October 29, 2024 15:13
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner October 29, 2024 15:13
@bnussman-akamai bnussman-akamai requested review from AzureLatte and removed request for a team October 29, 2024 15:13
@bnussman-akamai bnussman-akamai force-pushed the UIE-8007-dbaas-fix-display-host branch from 2127083 to 223fa0c Compare October 29, 2024 15:16
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corya-akamai looks like the the database details page is broken when tried to access the database is in provisioning state.
image

@cpathipa cpathipa added Hotfix Hotfix: This is going to staging and removed Hotfix Hotfix: This is going to staging labels Oct 29, 2024
@bnussman-akamai bnussman-akamai added the Hotfix Hotfix: This is going to staging label Oct 29, 2024
@corya-akamai
Copy link
Contributor Author

@corya-akamai looks like the the database details page is broken when tried to access the database is in provisioning state. image

Strange. I'm able to render GA and beta summary.

Screenshot 2024-10-29 at 11 30 34 AM
Screenshot 2024-10-29 at 11 30 04 AM

@bnussman-akamai
Copy link
Member

@cpathipa

I'm not seeing any crashes. I verified both legacy DBaaS and new DBaaS. I will continue testing

@cpathipa
Copy link
Contributor

Interesting I'm able to reproduce page crash when navigating to details page.

DBaaS.Database.details.page.crash.mov

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed I see the primary hostname (and private/read-only hostname) for both legacy Databases and new Databases ✅

@bnussman-akamai
Copy link
Member

@cpathipa You are running into a Vite caching issue. Try clearing the Vite cache and your browser cache.

rm -r packages/manager/node_modules/.vite

coliu-akamai
coliu-akamai previously approved these changes Oct 29, 2024
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any crashes either + confirmed hostnames showing up for legacy/new clusters! ✅

@cpathipa
Copy link
Contributor

cpathipa commented Oct 29, 2024

Thanks @bnussman thats cache issue, confirmed hostnames are showing up.

jaalah-akamai
jaalah-akamai previously approved these changes Oct 29, 2024
cpathipa
cpathipa previously approved these changes Oct 29, 2024
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@bnussman-akamai bnussman-akamai dismissed stale reviews from jaalah-akamai, coliu-akamai, and themself via 84431ad October 29, 2024 16:34
@bnussman-akamai bnussman-akamai merged commit cd09dd3 into linode:staging Oct 29, 2024
21 of 22 checks passed
Copy link

cypress bot commented Oct 29, 2024

Cloud Manager E2E    Run #6750

Run Properties:  status check passed Passed #6750  •  git commit cd09dd3edd: fix: [UIE-8007] - DBaaS display host in summary details (#11182)
Project Cloud Manager E2E
Branch Review staging
Run status status check passed Passed #6750
Run duration 25m 50s
Commit git commit cd09dd3edd: fix: [UIE-8007] - DBaaS display host in summary details (#11182)
Committer corya-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 441
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBaaS Relates to Database as a Service Hotfix Hotfix: This is going to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants