-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [UIE-8007] - DBaaS display host in summary details #11182
fix: [UIE-8007] - DBaaS display host in summary details #11182
Conversation
1ddea47
to
2127083
Compare
Coverage Report: ✅ |
2127083
to
223fa0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corya-akamai looks like the the database details page is broken when tried to access the database is in provisioning state.
Strange. I'm able to render GA and beta summary. |
I'm not seeing any crashes. I verified both legacy DBaaS and new DBaaS. I will continue testing |
Interesting I'm able to reproduce page crash when navigating to details page. DBaaS.Database.details.page.crash.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed I see the primary hostname (and private/read-only hostname) for both legacy Databases and new Databases ✅
@cpathipa You are running into a Vite caching issue. Try clearing the Vite cache and your browser cache.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing any crashes either + confirmed hostnames showing up for legacy/new clusters! ✅
Thanks @bnussman thats cache issue, confirmed hostnames are showing up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
84431ad
Cloud Manager E2E Run #6750
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
staging
|
Run status |
Passed #6750
|
Run duration | 25m 50s |
Commit |
cd09dd3edd: fix: [UIE-8007] - DBaaS display host in summary details (#11182)
|
Committer | corya-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
441
|
View all changes introduced in this branch ↗︎ |
Description 📝
Fix the display of host in DBaaS summary details
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
11/12/24
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply