refactor: [M3-8648] – Migrate Paper to ui package
#11183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwiley-akamai
requested review from
pmakode-akamai and
harsh-akamai
and removed request for
a team
dwiley-akamai
commented
Oct 29, 2024
Comment on lines
+27
to
+30
| export const omitProps = < | ||
| Props extends NonNullable<unknown>, | ||
| Keys extends keyof Props & string | ||
| >( |
There was a problem hiding this comment.
This change is due to this:
I went with the option that seemed to best maintain parity, but we can revisit if necessary.
|
Putting this back into draft status until the errors related to |
…build-ui as a need for test-manager in ci.yml
There was a problem hiding this comment.
Other comments:
- Unit test failure appears unrelated
- We should update the import from the example in
02-component-structure.md:L20
|
Coverage Report: ❌ |
Cloud Manager UI test results🎉 445 passing tests on test run #17 ↗︎
|
harsh-akamai
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
- Paper in Cloud ✅
- Code Review ✅
Thanks for the changes @dwiley-akamai! 🚀
bnussman-akamai
approved these changes
Nov 4, 2024
bnussman-akamai
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 19s |
| Commit |
|
| Committer | Dajahi Wiley |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Migrate
Paperfrommanagertouipackage.Target release date 🗓️
11/12/24
How to test 🧪
Verification steps
As an Author I have considered 🤔