Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-8194] - DBaaS Upgrades and Maintenance 1 #11196

Merged

Conversation

corya-akamai
Copy link
Contributor

Description 📝

DBaaS Upgrades and Maintenance 1 of 4

Changes 🔄

List any change relevant to the reviewer.

  • Add API to apply security patches (outside maintenance window)
  • Refactor database types (alphabetize properties, annotate with JS docs deprecatations and new properties
  • Add query for new API
  • Add mock data for new properties to factory

Target release date 🗓️

11/12/24

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@corya-akamai corya-akamai requested a review from a team as a code owner October 31, 2024 19:20
@corya-akamai corya-akamai requested review from dwiley-akamai and coliu-akamai and removed request for a team October 31, 2024 19:20
@coliu-akamai coliu-akamai added the DBaaS Relates to Database as a Service label Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

Coverage Report:
Base Coverage: 87.22%
Current Coverage: 87.22%

@corya-akamai corya-akamai force-pushed the UIE-8194-dbaas-major-minor-upgrades-1 branch from 6969e61 to cbc7f98 Compare November 1, 2024 12:55
@cpathipa cpathipa requested review from cpathipa and removed request for dwiley-akamai November 1, 2024 13:33
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some test flake on DatabaseResize.test.tsx that would be nice to fix

@cpathipa cpathipa removed the request for review from coliu-akamai November 1, 2024 14:17
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved pending on addressing feedback of @bnussman-akamai

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Nov 1, 2024
@corya-akamai corya-akamai force-pushed the UIE-8194-dbaas-major-minor-upgrades-1 branch from cbc7f98 to 11c4210 Compare November 1, 2024 16:40
@corya-akamai
Copy link
Contributor Author

corya-akamai commented Nov 1, 2024

DatabaseResize.test.tsx

@mpolotsk-akamai is this test fixed in your PR #11180?

FAIL src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.test.tsx > database resize > on rendering of page and isDatabasesV2GA is true and the Dedicated CPU tab is preselected > should render node selection for dedicated tab with default summary
TestingLibraryElementError: Unable to find an element by: [data-testid="database-node-2"]

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 1, 2024
@cpathipa cpathipa merged commit b1f2b24 into linode:develop Nov 1, 2024
22 of 23 checks passed
Copy link

cypress bot commented Nov 1, 2024

Cloud Manager E2E    Run #6773

Run Properties:  status check failed Failed #6773  •  git commit b1f2b249e0: feat: [UIE-8194] - DBaaS Upgrades and Maintenance 1 (#11196)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6773
Run duration 29m 24s
Commit git commit b1f2b249e0: feat: [UIE-8194] - DBaaS Upgrades and Maintenance 1 (#11196)
Committer corya-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 444
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/linode-config.spec.ts • 1 failed test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  linodes/switch-linode-state.spec.ts • 1 flaky test

View Output Video

Test Artifacts
switch linode state > powers on a linode from landing page Screenshots Video
Flakiness  linodes/resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by increasing size when offline: cold migration Screenshots Video
Flakiness  linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  firewalls/migrate-linode-with-firewall.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Migrate Linode With Firewall > migrates linode with firewall - real data Screenshots Video
Flakiness  nodebalancers/smoke-create-nodebal.spec.ts • 1 flaky test

View Output Video

Test Artifacts
create NodeBalancer > creates a NodeBalancer in a region with base pricing Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants