Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [M3-8818] Update .env.example cypress warning #11202

Merged
merged 2 commits into from
Nov 1, 2024
Merged

change: [M3-8818] Update .env.example cypress warning #11202

merged 2 commits into from
Nov 1, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Nov 1, 2024 •
edited
Loading

Description 📝

The existing .env.example Cypress warning makes it seem like using cypress will delete all your existing resources, which made some users weary of using the feature locally.

Changes 🔄

  • Update .env.example cypress warning

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Nov 1, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review November 1, 2024 15:05
@abailly-akamai abailly-akamai requested a review from a team as a code owner November 1, 2024 15:05
@abailly-akamai abailly-akamai requested review from bnussman-akamai, jaalah-akamai and jdamore-linode and removed request for a team November 1, 2024 15:05
jdamore-linode
jdamore-linode approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Thanks @abailly-akamai!

mjac0bs
mjac0bs approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 I remember finding this scary during my first week on this team before discovering it was misleading and forgetting about it. It's been overdue for an update. Thank you!

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Nov 1, 2024
@abailly-akamai abailly-akamai merged commit 8ed5a49 into linode:develop Nov 1, 2024
23 checks passed
@cypress Cypress
Copy link

cypress bot commented Nov 1, 2024

Cloud Manager E2E    Run #6768

Run Properties:  status check passed Passed #6768  •  git commit 8ed5a49b86: change: [M3-8818] Update .env.example cypress warning (#11202)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6768
Run duration 27m 24s
Commit git commit 8ed5a49b86: change: [M3-8818] Update .env.example cypress warning (#11202)
Committer Alban Bailly
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 445
View all changes introduced in this branch ↗︎

@jaalah-akamai jaalah-akamai mentioned this pull request Nov 7, 2024
Merged
@hana-akamai hana-akamai mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaalah-akamai jaalah-akamai jaalah-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

@jdamore-linode jdamore-linode jdamore-linode approved these changes

Assignees

@abailly-akamai abailly-akamai

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abailly-akamai @jdamore-linode @mjac0bs @bnussman-akamai @jaalah-akamai