refactor: [M3-8649] - Move Radio to at linode/ui package
#11244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakode-akamai
requested review from
carrillo-erik and
harsh-akamai
and removed request for
a team
|
Coverage Report: ❌ |
4 tasks
pmakode-akamai
force-pushed
the
M3-8649-move-radio-to-ui-package
branch
from
6087398 to
f02f31f
Compare
pmakode-akamai
requested review from
cliu-akamai
and removed request for
a team
jcallahan-akamai
changed the title
Radio to @linode/ui packageRadio to at linode/ui package
coliu-akamai
approved these changes
Nov 14, 2024
harsh-akamai
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Code Review ✅
Changes in Cloud ✅
Thanks @pmakode-akamai for this and the PRs blocking to this component! 🎉
hkhalil-akamai
added
Approved
pmakode-akamai
force-pushed
the
M3-8649-move-radio-to-ui-package
branch
from
c85a903 to
bb2e40d
Compare
Cloud Manager UI test results🎉 445 passing tests on test run #10 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 49s |
| Commit |
|
| Committer | Purvesh Makode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
Nov 15, 2024
…#11244) * Migrate radio to ui package * Add vitest imports in Radio tests * Fix radio icons imports * Add `vite-plugin-svgr` plugin to UI package * Added changeset: Move `Radio` from `manager` to `ui` package * Reordering imports * Temporarily import `FormControlLabel` from MUI * Remove typecast from plugin configuration in all places * Fix: avoid imports from @linode/ui in @linode/ui * Remove todo comments
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
Nov 15, 2024
…#11244) * Migrate radio to ui package * Add vitest imports in Radio tests * Fix radio icons imports * Add `vite-plugin-svgr` plugin to UI package * Added changeset: Move `Radio` from `manager` to `ui` package * Reordering imports * Temporarily import `FormControlLabel` from MUI * Remove typecast from plugin configuration in all places * Fix: avoid imports from @linode/ui in @linode/ui * Remove todo comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Moves the
Radiocomponent, story and unit tests to the@linode/uipackage and updates existing imports.Changes 🔄
vite-plugin-svgrplugin to@linode/uipackageTarget release date 🗓️
N/A
How to test 🧪
As an Author I have considered 🤔
Check all that apply