-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DI-20934] - Configurable Max limit on resource selection component #11252
upcoming: [DI-20934] - Configurable Max limit on resource selection component #11252
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified:
- Any selections beyond the max limit are disabled
- The Select All option is only present when the number of resource options is less than the limit
- Test coverage is present and passing
Thanks @ankitaakamai, approving pending a couple of comments I left are addressed. I also called out one question about buggy UI behavior to see if the team is aware of it.
packages/manager/src/features/CloudPulse/shared/CloudPulseResourcesSelect.tsx
Outdated
Show resolved
Hide resolved
packages/manager/.changeset/pr-11252-upcoming-features-1731490251541.md
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/shared/CloudPulseResourcesSelect.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/shared/CloudPulseResourcesSelect.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ✅
Verified changes in UI ✅
Thanks for the changes 🎉
Cloud Manager UI test results🎉 445 passing tests on test run #7 ↗︎
|
@jaalah Are we good to merge this PR? Thanks!! |
CI got hung up on needing an approval for the tests. Now that I've approved those and they've run, this looks good for merging. I'll merge, since Jaalah has already approved. |
Cloud Manager E2E Run #6828
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6828
|
Run duration | 28m 28s |
Commit |
727dc753f1: upcoming: [DI-20934] - Configurable Max limit on resource selection component (#...
|
Committer | ankitaakamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
444
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
linode landing checks for non-empty state with restricted user > checks restricted user with read access has no access to create linode and can see existing linodes |
Screenshots
Video
|
linodes/linode-config.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Linode Config management > End-to-End > Boots a config |
Screenshots
Video
|
objectStorageGen2/bucket-object-gen2.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Object Storage Gen2 bucket object tests > can check Object details drawer with E0 endpoint type |
Screenshots
Video
|
volumes/delete-volume.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
volume delete flow > deletes a volume |
Screenshots
Video
|
Description 📝
Introduction of configurable Max limit on resource selection component and other enhancements.
Changes 🔄
limit
label
' is introduced under resource selection autocomplete.Target release date 🗓️
12-12-2024
Preview 📷
How to test 🧪
Verification steps
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅