-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8872] - Table and Chart Legend Improvements #11294
Conversation
Will update branch soon... |
packages/manager/src/features/CloudPulse/shared/CloudPulseResourcesSelect.tsx
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/shared/CloudPulseResourcesSelect.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: ✅ |
Cloud Manager UI test results🔺 3 failing tests on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the spacing is improved and expected test coverage passes.
Screen.Recording.2024-11-25.at.2.23.46.PM.mov
@jaalah-akamai one thing seen in y-axis that for a very low max value when recharts generating all the y-axis ticks, some tick points are going to 4 decimal places. As you can see, values like 0.0075 or 0.0225 are not properly visible as y-axis tick. Can we add some kind of padding or formatter for the value? |
I added the ability to use the built-in formatter, so you can apply whatever you need in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ styling changes in tables in graphs + across the board
thank you!
Cloud Manager E2E Run #6886
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6886
|
Run duration | 30m 30s |
Commit |
afa6da9f35: fix: [M3-8872] - Table and Chart Legend Improvements (#11294)
|
Committer | Jaalah Ramos |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
2
|
Pending |
2
|
Skipped |
0
|
Passing |
454
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/rebuild-linode.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
rebuild linode > rebuilds a linode from Account StackScript |
Screenshots
Video
|
linodes/switch-linode-state.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
switch linode state > powers off a linode from landing page |
Screenshots
Video
|
firewalls/migrate-linode-with-firewall.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Migrate Linode With Firewall > migrates linode with firewall - real data |
Screenshots
Video
|
Description 📝
We needed to reduce the spacing for our table headers to match our CDS as well as within our legend table.
Changes 🔄
Target release date 🗓️
12/10
Preview 📷
How to test 🧪
Reproduction steps
Verification steps
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅