upcoming: [DI-22217] - Added the Alert Listing page with Alerting Table and added relevant api endpoints #11346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, Table rows and added the GET api endpoint and mockServer for fetching alert definitions
…or the AlertListing Table and minor changes
santoshp210-akamai
requested review from
bnussman-akamai and
coliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
|
There are still on-going discussions with respect to the columns of the table in the Mockups with UX team, These are the currently agreed upon changes, there's a possibility of couple of columns re ordered or removed. |
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.test.tsx
Outdated
Show resolved
Hide resolved
…ses, unabbreviated UT to Unit Tests in changeset
There was a problem hiding this comment.
This file will be replaced before the PR is merged as the icon is not looking good on the UI. There are some confirmations from the UX side.
We will omit the file and then add the icon when we receive it from the UX team.
bnussman-akamai
requested changes
Dec 3, 2024
packages/manager/src/features/CloudPulse/Alerts/AlertsLanding/AlertsDefinitionLanding.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertActionMenu.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertActionMenu.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
…ved waitFor in the unit tests and removed Severity column, removed the Placeholder Icon for Alerts Landing empty state
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertTableRow.tsx
Outdated
Show resolved
Hide resolved
…he TableHead Row, Replaced referencing colors directly and used theme styling for colors
bnussman-akamai
approved these changes
Dec 5, 2024
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+29
to
+39
| <TableCell> | ||
| <Typography | ||
| color={ | ||
| status === 'enabled' | ||
| ? theme.tokens.color.Green[70] | ||
| : theme.tokens.color.Neutrals[60] | ||
| } | ||
| > | ||
| {capitalize(status)} | ||
| </Typography> | ||
| </TableCell> |
There was a problem hiding this comment.
This is fine but I'm wondering why UX didn't just use our Status Icon
bnussman-akamai
added
Add'tl Approval Needed
…er AlertListingTableLabelMap, used shorthand
jaalah-akamai
approved these changes
Dec 6, 2024
|
@santoshp210-akamai Update with latest from develop and we'll merge this - it's good to go |
jaalah-akamai
added
Approved
merging latest changes from linode/develop
Cloud Manager UI test results🎉 466 passing tests on test run #11 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 32m 30s |
| Commit |
|
| Committer | santoshp210-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
466
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/linode-config.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
switch-linode-state.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| switch linode state > reboots a linode from details page |
Screenshots
Video
|
|
update-linode-labels.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| update linode label > updates a linode label from the "Settings" tab |
Screenshots
Video
|
|
backup-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| linode backups > can enable backups |
Screenshots
Video
|
|
search-linodes.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Search Linodes > create a linode and make sure it shows up in the table and is searchable in main search tool |
Screenshots
Video
|
|
rescue-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Rescue Linodes > Can reboot a Linode into rescue mode |
Screenshots
Video
|
|
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes 🔄
List any change(s) relevant to the reviewer.
GETrequest to fetch the alert definitionsAlertDefinitionTypeto'system'|'user'Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
How to test 🧪
Prerequisites
aclpAlerting, the flag has been currently disabled. For testing enable the definitions part of theaclpAlertingflag to be true.Verification steps
(How to verify changes)
/monitor/alerts/definitionsis the AlertListing componentAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅