-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use Query Key Factor for Object ACL and Fix Incorrect api-v4 type #11369
Merged
bnussman-akamai
merged 2 commits into
linode:develop
from
bnussman-akamai:chore/use-query-key-factory-for-object-acl
Dec 6, 2024
Merged
refactor: Use Query Key Factor for Object ACL and Fix Incorrect api-v4 type #11369
bnussman-akamai
merged 2 commits into
linode:develop
from
bnussman-akamai:chore/use-query-key-factory-for-object-acl
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
@linode/api-v4
Changes are made to the @linode/api-v4 package
Object Storage
deals with Object Storage
labels
Dec 4, 2024
bnussman-akamai
requested review from
cpathipa and
abailly-akamai
and removed request for
a team
December 4, 2024 18:09
Coverage Report: ✅ |
Cloud Manager UI test results🎉 465 passing tests on test run #2 ↗︎
|
abailly-akamai
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thanks for fixing
cpathipa
approved these changes
Dec 6, 2024
cpathipa
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Dec 6, 2024
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Multiple approvals and ready to merge!
@linode/api-v4
Changes are made to the @linode/api-v4 package
Object Storage
deals with Object Storage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
useObjectAccess
query to use our query key factory for consistency 🏭updateObjectACL
api-v4 function 🔧Preview 📷
Note
No UI changes are expected. This screenshot just shows where this query is used.
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅