Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Query Key Factor for Object ACL and Fix Incorrect api-v4 type #11369

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • Updates Object Storage useObjectAccess query to use our query key factory for consistency 🏭
  • Fixes incorrect return type of updateObjectACL api-v4 function 🔧

Preview 📷

Note

No UI changes are expected. This screenshot just shows where this query is used.

Screenshot 2024-12-04 at 1 07 17 PM

How to test 🧪

  • Create an Object Storage bucket (or use an existing bucket)
  • Add a new object (or use an existing object)
  • Verify you can change the ACL for an object
  • Verify the React Query cache updates correctly and the UI works as expected
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added @linode/api-v4 Changes are made to the @linode/api-v4 package Object Storage deals with Object Storage labels Dec 4, 2024
@bnussman-akamai bnussman-akamai self-assigned this Dec 4, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner December 4, 2024 18:09
@bnussman-akamai bnussman-akamai requested review from cpathipa and abailly-akamai and removed request for a team December 4, 2024 18:09
Copy link

github-actions bot commented Dec 4, 2024

Coverage Report:
Base Coverage: 86.85%
Current Coverage: 86.85%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 465 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing465 Passing2 Skipped103m 59s

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for fixing

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 5, 2024
@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 6, 2024
@bnussman-akamai bnussman-akamai merged commit dcf380b into linode:develop Dec 6, 2024
23 checks passed
Copy link

cypress bot commented Dec 6, 2024

Cloud Manager E2E    Run #6933

Run Properties:  status check failed Failed #6933  •  git commit dcf380b298: refactor: Use Query Key Factor for Object ACL and Fix Incorrect api-v4 type (#11...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6933
Run duration 35m 11s
Commit git commit dcf380b298: refactor: Use Query Key Factor for Object ACL and Fix Incorrect api-v4 type (#11...
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 462
View all changes introduced in this branch ↗︎

Tests for review

Failed  linodes/linode-config.spec.ts • 1 failed test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Failed  linodes/rebuild-linode.spec.ts • 2 failed tests

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Community StackScript Screenshots Video
rebuild linode > rebuilds a linode from Account StackScript Screenshots Video
Failed  billing/smoke-billing-activity.spec.ts • 1 failed test

View Output Video

Test Artifacts
Billing Activity Feed > displays correct timezone for invoice and payment dates Screenshots Video
Flakiness  linodes/resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by decreasing size Screenshots Video
Flakiness  stackscripts/create-stackscripts.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Create stackscripts > creates a StackScript with Any/All target image Screenshots Video
Flakiness  linodes/search-linodes.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Search Linodes > create a linode and make sure it shows up in the table and is searchable in main search tool Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! @linode/api-v4 Changes are made to the @linode/api-v4 package Object Storage deals with Object Storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants