fix: [M3-8975] - Object Storage object uploader spinner spinning backwards #11384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-akamai
requested review from
hana-akamai and
hkhalil-akamai
and removed request for
a team
hana-akamai
reviewed
Dec 9, 2024
| @@ -51,7 +51,7 @@ export const StyledRightWrapper = styled('div', { | |||
| export const StyledUploadPending = styled(UploadPending, { | |||
| label: 'StyledUploadPending', | |||
| })(({ theme }) => ({ | |||
| animation: `${rotate360} 2s linear infinite`, | |||
| animation: `${rotate360CounterClockwise} 2s linear infinite`, | |||
There was a problem hiding this comment.
I think the goal was for the arrows to point and spin clockwise. Imo, we should either use the mui AutorenewIcon similar to the NotificationMenu component or horizontally flip the UploadPending svg so that the arrows are pointing the right way
There was a problem hiding this comment.
Noted. I've pushed the changes!
harsh-akamai
changed the title
|
Coverage Report: ✅ |
hana-akamai
approved these changes
Dec 10, 2024
hana-akamai
added
Add'tl Approval Needed
hkhalil-akamai
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Thanks for the fix! Approved pending @hana-akamai's suggestion.
hkhalil-akamai
added
Approved
Cloud Manager UI test results🎉 469 passing tests on test run #5 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 31m 20s |
| Commit |
|
| Committer | Harsh Shankar Rao |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
468
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
|
cypress/e2e/core/parentChild/account-switching.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Parent/Child account switching > From Parent to Child > can switch from Parent account user to Proxy account user from Billing page |
Screenshots
Video
|
|
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Object Storage object uploader spinner spins backwards
Changes 🔄
The spinner spins in the same direction the arrows point
Target release date 🗓️
N/A
Preview 📷
Screen.Recording.2024-12-10.at.10.47.05.PM.mov
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅