fix: [UIE-8194] dbaas maintenance pending updates state should display when any pending updates are available #11387

smans-akamai · 2024-12-09T16:55:08Z

Description 📝

For DBaaS maintenance feature, the pending updates state should display when there are any pending updates available for a DB cluster. It should also disable the option to upgrade the version while those updates are still pending.

Changes 🔄

List any change(s) relevant to the reviewer.

Fix check for pending updates so it will check for any available pending updates instead of only ones with a defined deadline or planned_for property.
Update disabling behavior for the Upgrade Version button in the DBaaS settings maintenance field so that it will disable when there are pending updates
When there are pending updates to disable Upgrade Version. Have a "?" icon to the right of the temporarily disabled Upgrade Version button with tip text:
"Upgrades are disabled while maintenance updates are in progress."

Target release date 🗓️

1/14/25

Preview 📷

Before	After

How to test 🧪

Prerequisites

Managed Databases
dbaasV2 feature flag set for GA
Default DB created e.g. postgresql 13

Reproduction steps

Having a pending update available where deadline and the planned_for property are both null
In settings, see that both the Maintenance updates does not show review state
In settings, see that Upgrade Version button is enabled even with pending updates.

Verification steps

Verify that Maintenance field in DBaaS settings displays pending updates display pending update review state when pending updates are available.
Verify that Upgrade Version is disabled even if there are available version updates.
Verify that ? icon appears next to disabled Upgrade Version button when there are pending updates available

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All unit tests are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

github-actions · 2024-12-09T18:53:58Z

Coverage Report: ✅
Base Coverage: 86.84%
Current Coverage: 86.84%

…y when any pending updates are available and disable version upgrade

smans-akamai · 2024-12-10T18:40:47Z

...nager/src/features/Databases/DatabaseDetail/DatabaseSettings/DatabaseSettingsMaintenance.tsx

          onClick={onUpgradeVersion}
        >
          Upgrade Version
        </StyledLinkButton>
+        {hasUpdates && (


@cpathipa The update was to have a Tooltip icon display when there are pending updates disabling the Upgrade Version button. Just pushed up another change to adjust the condition and I've updated the description.

linode-gh-bot · 2024-12-10T19:25:26Z

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`1 Failing`	`465 Passing`	`2 Skipped`	`104m 15s`

Details

Failing Tests
	Spec	Test
❌	`smoke-billing-activity.spec.ts`	Billing Activity Feed » displays correct timezone for invoice and payment dates

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/billing/smoke-billing-activity.spec.ts"

abailly-akamai

Thanks for the contribution @smans-akamai - code looks good

Could we maybe use a server handler (or updating the factory if already handled) to mock a pending update to easily verify the change for now and future proofing? I was unable to verify the change since there's no pending update for the DB instances I am creating.

abailly-akamai · 2024-12-11T14:42:26Z

packages/manager/src/features/Databases/utilities.ts

-  Boolean(
-    pendingUpdates?.some((update) => update.deadline || update.planned_for)
-  );
+  Boolean(pendingUpdates && pendingUpdates?.length > 0);


Suggested change

Boolean(pendingUpdates && pendingUpdates?.length > 0);

Boolean(pendingUpdates?.length > 0);

@abailly-akamai The pendingUpdates param is optional and can be undefined. So this change throws a "possibly undefined" typescript error without the added check. I believe the function was intentionally written this way so I'd prefer to leave it the as is.

Also, for the components using this method, the property that gets provided for pendingUpdates is optional. Perhaps because the data might not be available right away before making this check.

Since this just a fix for the existing behavior, can we leave it as is?

sure thing, I just assumed the optional chaining was taking care of that 👍

smans-akamai · 2024-12-11T15:48:07Z

Thanks for the contribution @smans-akamai - code looks good

Could we maybe use a server handler (or updating the factory if already handled) to mock a pending update to easily verify the change for now and future proofing? I was unable to verify the change since there's no pending update for the DB instances I am creating.

Thanks @abailly-akamai! The pending update is already mocked in the ServerHandler. Pending updates are included in the DB factory by default. This was done when the feature was originally implemented.
https://github.com/linode/manager/blob/develop/packages/manager/src/mocks/serverHandlers.ts#L269

If you change the pending updates array in the factory to an empty array, it should toggle this behavior in your local.
https://github.com/linode/manager/blob/develop/packages/manager/src/factories/databases.ts#L224

abailly-akamai · 2024-12-11T18:23:58Z

@smans-akamai that worked - It just won't do that with every cluster ID so I did not see it with the one I tried

for reference, /databases/mysql/19/settings while mocking with legacy server handlers will work 👍

jaalah-akamai

✅ Changes look good - thanks @alban for the route to test 👍

cypress · 2024-12-12T17:37:37Z

Cloud Manager E2E Run #6961

Run Properties: Passed #6961 • 15992df8c7: fix: [UIE-8194] dbaas maintenance pending updates state should display when any ...

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Passed #6961`
Run duration	`28m 55s`
Commit	`15992df8c7: fix: [UIE-8194] dbaas maintenance pending updates state should display when any ...`
Committer	`smans-akamai`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`469`
View all changes introduced in this branch ↗︎

smans-akamai requested a review from a team as a code owner December 9, 2024 16:55

smans-akamai requested review from abailly-akamai and harsh-akamai and removed request for a team December 9, 2024 16:55

smans-akamai force-pushed the UIE-8194-dbaas-settings-maintenance-pending-update-fix branch from febef64 to 4c771ae Compare December 9, 2024 18:21

cpathipa assigned smans-akamai Dec 9, 2024

cpathipa added the DBaaS Relates to Database as a Service label Dec 9, 2024

cpathipa requested review from cpathipa and removed request for harsh-akamai December 9, 2024 20:27

smans-akamai force-pushed the UIE-8194-dbaas-settings-maintenance-pending-update-fix branch from 4c771ae to 5e34741 Compare December 10, 2024 17:29

fix: [UIE-8194] dbaas maintenance pending updates state should displa…

a28bb9f

…y when any pending updates are available and disable version upgrade

smans-akamai force-pushed the UIE-8194-dbaas-settings-maintenance-pending-update-fix branch from 5e34741 to a28bb9f Compare December 10, 2024 18:37

smans-akamai commented Dec 10, 2024

View reviewed changes

abailly-akamai reviewed Dec 11, 2024

View reviewed changes

smans-akamai requested a review from abailly-akamai December 11, 2024 16:01

abailly-akamai approved these changes Dec 11, 2024

View reviewed changes

jaalah-akamai approved these changes Dec 12, 2024

View reviewed changes

jaalah-akamai added the Approved Multiple approvals and ready to merge! label Dec 12, 2024

cpathipa approved these changes Dec 12, 2024

View reviewed changes

cpathipa merged commit 15992df into linode:develop Dec 12, 2024
21 of 23 checks passed

This was referenced Jan 8, 2025

Release v1.134.0 - release → staging #11494

Closed

Release v1.134.0 - release → staging #11497

Merged

Release v1.134.0 - release → staging #11503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: [UIE-8194] dbaas maintenance pending updates state should display when any pending updates are available #11387

fix: [UIE-8194] dbaas maintenance pending updates state should display when any pending updates are available #11387

smans-akamai commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024

smans-akamai Dec 10, 2024 •

edited

Loading

linode-gh-bot commented Dec 10, 2024

abailly-akamai left a comment

abailly-akamai Dec 11, 2024

smans-akamai Dec 11, 2024 •

edited

Loading

abailly-akamai Dec 11, 2024

smans-akamai commented Dec 11, 2024 •

edited

Loading

abailly-akamai commented Dec 11, 2024 •

edited

Loading

jaalah-akamai left a comment

cypress bot commented Dec 12, 2024

	Boolean(pendingUpdates && pendingUpdates?.length > 0);
	Boolean(pendingUpdates?.length > 0);

fix: [UIE-8194] dbaas maintenance pending updates state should display when any pending updates are available #11387

fix: [UIE-8194] dbaas maintenance pending updates state should display when any pending updates are available #11387

Conversation

smans-akamai commented Dec 9, 2024 • edited Loading

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Reproduction steps

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

github-actions bot commented Dec 9, 2024

smans-akamai Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

linode-gh-bot commented Dec 10, 2024

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

Details

Troubleshooting

abailly-akamai left a comment

Choose a reason for hiding this comment

abailly-akamai Dec 11, 2024

Choose a reason for hiding this comment

smans-akamai Dec 11, 2024 • edited Loading

Choose a reason for hiding this comment

abailly-akamai Dec 11, 2024

Choose a reason for hiding this comment

smans-akamai commented Dec 11, 2024 • edited Loading

abailly-akamai commented Dec 11, 2024 • edited Loading

jaalah-akamai left a comment

Choose a reason for hiding this comment

cypress bot commented Dec 12, 2024

Cloud Manager E2E Run #6961

smans-akamai commented Dec 9, 2024 •

edited

Loading

smans-akamai Dec 10, 2024 •

edited

Loading

smans-akamai Dec 11, 2024 •

edited

Loading

smans-akamai commented Dec 11, 2024 •

edited

Loading

abailly-akamai commented Dec 11, 2024 •

edited

Loading