test: [M3-8979] - Fix lke-create test by using a different mock region #11411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureLatte
requested review from
jdamore-linode
and removed request for
a team
AzureLatte
requested review from
cpathipa and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 469 passing tests on test run #2 ↗︎
|
mjac0bs
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Test looks good, thanks Azure! Were there more of these failures in other tests across CM as a result of using regions or other data unavailable in the staging environment? 😬
Reviewing this PR and running the tests locally made me realize an unrelated lke-create.spec.ts failure I need to fix - for anyone with the Kubernetes Enterprise capability on their account, the final test in the spec is going to fail on local runs because we need to mock that the capability is not present, as the test expects. I'm going to include that in my changes for M3-8928.
hkhalil-akamai
approved these changes
Dec 12, 2024
hkhalil-akamai
added
Approved
jdamore-linode
approved these changes
Dec 13, 2024
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
linode#11411) * Fix lke-create test by using a different mock region * Added changeset: Update mock region for LKE cluster creation test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The "can dynamically update prices when creating an LKE cluster based on region" test in lke-create.spec.ts fails when running against the staging API because only the Dallas region is available for LKE creation but the test assumes Newark is present. Fix the test by using a different mock region.
Changes 🔄
List any change(s) relevant to the reviewer.
How to test 🧪
To reproduce the issue locally you’ll want to set your REACT_APP_API_ROOT var in .env to the staging URL. You might also have to set REACT_APP_LOGIN_ROOT to the login staging URL, then run the following command
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅