fix: [M3-7528] - Account Cancellation Survey Button Color Issues #11412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrillo-erik
requested review from
hkhalil-akamai and
pmakode-akamai
and removed request for
a team
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Nice work @carrillo-erik, thanks! Confirmed that the logo and button both look as expected with the dark and light theme
coliu-akamai
approved these changes
Dec 13, 2024
coliu-akamai
added
Approved
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 17s |
| Commit |
|
| Committer | carrillo-erik |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
469
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
…ode#11412) * fix : [M3-7528] - Account Cancellation Survey Button Color Issues * Add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The original bug reported was that the action button on the Account Cancellation page would change from green to blue when the user would hover over it. However, an additional bug was discovered in which the Akamai logo would not display properly in Light Mode. This PR addresses both issues by updating the color of the action button to be consistent with the rest of the application, as well as its state behaviors in Light and Dark modes, and displaying the Akamai log in color when the user is in Light Mode.
Changes 🔄
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
yarn cy:run -s "cypress/e2e/core/account/account-cancellation.spec.ts"Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅