Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-6546] - Volume drawers and action menu refactored #11421

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

dchyrva-akamai
Copy link
Contributor

@dchyrva-akamai dchyrva-akamai commented Dec 16, 2024

Description 📝

Created new drawer for managing volume tags, action menu for the volume row updated.

Changes 🔄

  • Removed "Show Config" button from the volume table row and added to the actions menu.

  • Remove "Edit" button from the volume table row and added to the actions menu .

  • Added "Manage Tags" option to the volume table actions menu.

  • Added new "Manage Tags" drawer.

  • Existing volume tags functionality moved from "Edit Volume" drawer to "Manage Tags" drawer.

Preview 📷

image
image

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dchyrva-akamai dchyrva-akamai requested review from a team as code owners December 16, 2024 09:17
@dchyrva-akamai dchyrva-akamai requested review from jdamore-linode, hkhalil-akamai and pmakode-akamai and removed request for a team December 16, 2024 09:17
@dchyrva-akamai dchyrva-akamai marked this pull request as draft December 16, 2024 09:17
Copy link

github-actions bot commented Dec 16, 2024

Coverage Report:
Base Coverage: 86.98%
Current Coverage: 86.98%

@dchyrva-akamai
Copy link
Contributor Author

dchyrva-akamai commented Dec 16, 2024

@skulpok-akamai @jdamore-linode @hkhalil-akamai Hello and thank you for you patience, I had to switch to the Netstorage for a while.
I have recreated this PR and synchronized the branch with the latest develop branch.

As far as I understand, the last blocking factor there was the cleanUp call inside of the after method right?

As I had mentioned before, I added it to remove volumes from my account created by the e2e test.

Steps to reproduce the issue are quite simple, you can try them on your own machine:

  • Do git switch selecting this branch.
  • Run yarn cy:debug from the terminal.
  • Choose "Chrome".
  • Find update-volume.spec.ts using Cypress UI.
  • Run the test suit.
  • After the test run, kill the cypress process from the terminal.
  • Observe your "Volumes page":
    image

I personally would prefer not to delete them manually all the time, this is why added cleanUp at the end of the test.

@dchyrva-akamai dchyrva-akamai marked this pull request as ready for review December 16, 2024 10:27
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 467 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing467 Passing2 Skipped95m 48s

Copy link

github-actions bot commented Jan 1, 2025

This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days

@github-actions github-actions bot added the Stale label Jan 1, 2025
@github-actions github-actions bot removed the Stale label Jan 3, 2025
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pmakode-akamai pmakode-akamai added the Approved Multiple approvals and ready to merge! label Jan 7, 2025
@hkhalil-akamai hkhalil-akamai merged commit 6f907c2 into linode:develop Jan 7, 2025
23 checks passed
Copy link

cypress bot commented Jan 7, 2025

Cloud Manager E2E    Run #7042

Run Properties:  status check passed Passed #7042  •  git commit 6f907c2043: change: [M3-6546] - Volume drawers and action menu refactored (#11421)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7042
Run duration 29m 04s
Commit git commit 6f907c2043: change: [M3-6546] - Volume drawers and action menu refactored (#11421)
Committer Dmytro Chyrva
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 474
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants