-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-6546] - Volume drawers and action menu refactored #11421
Conversation
Coverage Report: ✅ |
069070d
to
2133015
Compare
@skulpok-akamai @jdamore-linode @hkhalil-akamai Hello and thank you for you patience, I had to switch to the Netstorage for a while. As far as I understand, the last blocking factor there was the cleanUp call inside of the after method right? As I had mentioned before, I added it to remove volumes from my account created by the e2e test. Steps to reproduce the issue are quite simple, you can try them on your own machine:
I personally would prefer not to delete them manually all the time, this is why added cleanUp at the end of the test. |
2133015
to
deaa653
Compare
Cloud Manager UI test results🎉 467 passing tests on test run #3 ↗︎
|
This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Cloud Manager E2E Run #7042
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #7042
|
Run duration | 29m 04s |
Commit |
6f907c2043: change: [M3-6546] - Volume drawers and action menu refactored (#11421)
|
Committer | Dmytro Chyrva |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
474
|
View all changes introduced in this branch ↗︎ |
Description 📝
Created new drawer for managing volume tags, action menu for the volume row updated.
Changes 🔄
Removed "Show Config" button from the volume table row and added to the actions menu.
Remove "Edit" button from the volume table row and added to the actions menu .
Added "Manage Tags" option to the volume table actions menu.
Added new "Manage Tags" drawer.
Existing volume tags functionality moved from "Edit Volume" drawer to "Manage Tags" drawer.
Preview 📷
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅