test: [M3-8863, M3-9040] - Cypress test to validate aria label of Linode IP Addresses/Ranges action menu #11435
Conversation
pmakode-akamai
added
the
e2e
pmakode-akamai
requested review from
AzureLatte
and removed request for
a team
…resses action menu
pmakode-akamai
requested review from
cpathipa and
coliu-akamai
and removed request for
a team
|
Coverage Report: ❌ |
coliu-akamai
added
Approved
There was a problem hiding this comment.
Thanks @pmakode-akamai! Left a comment about the second test in linode-network.spec.ts, and agree with @coliu-akamai about her unit test suggestion, but otherwise this is looking good!
| it('validates the action menu title (aria-label) for the IP address in the table row', () => { | ||
| // Set the viewport to 1279px x 800px (width < 1280px) to ensure the Action menu is visible. | ||
| cy.viewport(1279, 800); | ||
|
|
||
| // Ensure the action menu has the correct aria-label for the IP address. | ||
| cy.get(`[data-qa-ip="${linodeIPv4}"]`) | ||
| .should('be.visible') | ||
| .closest('tr') | ||
| .within(() => { | ||
| ui.actionMenu | ||
| .findByTitle(`Action menu for IP Address ${linodeIPv4}`) | ||
| .should('be.visible'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I don't think this is worth blocking the merge, but I think this test would be better as a unit test for LinodeNetworkingActionMenu.tsx.
There was a problem hiding this comment.
@jdamore-linode @coliu-akamai I’ve added the missing IP range test coverage in this PR as part of the changes. I understand the suggestion about moving this to a unit test for LinodeNetworkingActionMenu.tsx. Would it be okay to merge this PR as is (since we already have similar e2e coverage in the case of Domain Landing table action menu for aria-label), and I can follow up with a separate PR for the unit test? Let me know what works best.
|
@coliu-akamai @jdamore-linode Created a ticket (M3-9040) to validate the IP ranges as well edit: Added coverage for IP ranges in this PR ✅ |
pmakode-akamai
changed the title
Cloud Manager UI test results🎉 471 passing tests on test run #7 ↗︎
|
|
merging - Got confirmation async - ty! |
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 27s |
| Commit |
|
| Committer | Purvesh Makode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
472
|
| View all changes introduced in this branch ↗︎ | |
…ode IP Addresses/Ranges action menu (linode#11435) * Add cypress test to validate ip address table row action menu label * Few updates * Added changeset: Cypress test to validate aria label of Linode IP Addresses action menu * Add test coverage for ip range
Description 📝
Cypress test to validate ARIA label of Linode IP Addresses action menu
Changes 🔄
Target release date 🗓️
N/A
How to test 🧪
yarn cy:run -s "cypress/e2e/core/linodes/linode-network.spec.ts"Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅