test: [M3-8661] - Cypress test to validate CAA record are editable #11440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasyed-akamai
added
the
e2e
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Show resolved
Hide resolved
subsingh-akamai
approved these changes
Dec 26, 2024
hasyed-akamai
requested review from
jdamore-linode,
hkhalil-akamai and
coliu-akamai
and removed request for
a team
jdamore-linode
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Nice start @hasyed-akamai! Left some feedback, feel free to reach out if you have any questions!
Edit: sorry, meant to wait for feedback to be addressed before approving!
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Outdated
Show resolved
Hide resolved
|
Thank you, @jdamore-linode, for your valuable feedback. I’ve implemented all the changes you suggested. Please feel free to review them again when you have a chance. 😊 |
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
Jan 6, 2025
coliu-akamai
approved these changes
Jan 6, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@linode/manager": Added | |||
There was a problem hiding this comment.
changeset should be for Tests category
hkhalil-akamai
approved these changes
Jan 6, 2025
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/create-linode-region-select.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 27s |
| Commit |
|
| Committer | hasyed-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
473
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
…inode#11440) * test: [M3-8661] - Cypress test to validate CAA record are editable * Added changeset: Cypress test to validate CAA records are editable * Splitting the test cases for valid and invalid records * Move`createCaaRecord` and `verifyRecordInTable` function calls in `beforeEach` block * Add cleanup, use @example.com for emails, and replace `cy.get()` for stability. * Update Changeset type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Added Cypress test to validate CAA record are editable
Changes 🔄
Added below cypress tests under in spec file -
cypress/e2e/core/domains/smoke-create-domain-records.spec.ts2. Navigate to Domain details Landing page.
2. Validate creation of the CAA record with iodef tag.
3. Validate that it should update valid record and not allow invalid record.
4. Validate that it should throw a error "You have entered an invalid target" when update with invalid record.
How to test 🧪
yarn cy:run -s cypress/e2e/core/domains/smoke-create-domain-records.spec.tsVerification steps
When test executed using this command
yarn cy:run -s cypress/e2e/core/domains/smoke-create-domain-records.spec.tsall tests should pass successfully.As an Author I have considered 🤔
Check all that apply