Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-9042] - Update LKE cluster details kube specs for LKE-E monthly pricing #11475

Merged

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Jan 3, 2025

Description 📝

The cluster pricing in the Kube Specs on the LKE details page for an enterprise cluster does not currently match the price that was given when creating a cluster because the LKE-E HA price ($300/month) is not factored in. We need to update this to provide consistent and accurate pricing information for LKE-E clusters.

Changes 🔄

  • Updated the kube specs to correctly calculate LKE-E HA pricing ($300/month)
  • Updated lke-create.spec.ts with test coverage for this

Target release date 🗓️

1/14/25

Preview 📷

Before After
Screenshot 2025-01-03 at 1 26 08 PM Screenshot 2025-01-03 at 1 25 58 PM

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have the LKE-E enterprise tag on your account (see project tracker)
  • Ensure the LKE-E feature is on in dev tools (enabled + la)
  • Have an LKE-E cluster created on your account

Reproduction steps

(How to reproduce the issue, if applicable)

  • In prod/develop, go to the cluster details page for your LKE-E cluster and observe that the pricing is incorrect (it's using the regular HA pricing of $60/month + node pool cost)

Verification steps

(How to verify changes)

  • On this branch, go to the cluster details page for your LKE-E cluster and observe that the pricing is correct (uses the enterprise HA pricing of $300/month + node pool cost); it will be $240 higher
  • Confirm that standard LKE clusters are priced with the standard HA cost
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mjac0bs mjac0bs self-assigned this Jan 3, 2025
@mjac0bs mjac0bs requested review from a team as code owners January 3, 2025 21:28
@mjac0bs mjac0bs requested review from jdamore-linode, dwiley-akamai and hkhalil-akamai and removed request for a team January 3, 2025 21:28
Copy link

github-actions bot commented Jan 3, 2025

Coverage Report:
Base Coverage: 86.97%
Current Coverage: 86.97%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 471 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing471 Passing2 Skipped87m 53s

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified incorrect pricing shown in prod and correct HA price shown on this branch.

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Jan 6, 2025
@mjac0bs mjac0bs merged commit 3e74aca into linode:develop Jan 6, 2025
23 checks passed
Copy link

cypress bot commented Jan 6, 2025

Cloud Manager E2E    Run #7038

Run Properties:  status check passed Passed #7038  •  git commit 3e74aca19b: upcoming: [M3-9042] - Update LKE cluster details kube specs for LKE-E monthly pr...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7038
Run duration 27m 07s
Commit git commit 3e74aca19b: upcoming: [M3-9042] - Update LKE cluster details kube specs for LKE-E monthly pr...
Committer Mariah Jacobs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

dmcintyr-akamai pushed a commit to dmcintyr-akamai/manager that referenced this pull request Jan 9, 2025
… monthly pricing (linode#11475)

* Update price on cluster details page to include enterprise

* Update test coverage to confirm LKE-E creation details

* Added changeset: Update LKE cluster details kube specs for LKE-E monthly pricing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! LKE-Enterprise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants