-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-9042] - Update LKE cluster details kube specs for LKE-E monthly pricing #11475
Merged
mjac0bs
merged 3 commits into
linode:develop
from
mjac0bs:M3-9042-update-cluster-details-lke-e-pricing
Jan 6, 2025
Merged
upcoming: [M3-9042] - Update LKE cluster details kube specs for LKE-E monthly pricing #11475
mjac0bs
merged 3 commits into
linode:develop
from
mjac0bs:M3-9042-update-cluster-details-lke-e-pricing
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
requested review from
jdamore-linode,
dwiley-akamai and
hkhalil-akamai
and removed request for
a team
January 3, 2025 21:28
Coverage Report: ✅ |
Cloud Manager UI test results🎉 471 passing tests on test run #2 ↗︎
|
hkhalil-akamai
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified incorrect pricing shown in prod and correct HA price shown on this branch.
bnussman-akamai
approved these changes
Jan 6, 2025
hana-akamai
approved these changes
Jan 6, 2025
Cloud Manager E2E Run #7038
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #7038
|
Run duration | 27m 07s |
Commit |
3e74aca19b: upcoming: [M3-9042] - Update LKE cluster details kube specs for LKE-E monthly pr...
|
Committer | Mariah Jacobs |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
471
|
View all changes introduced in this branch ↗︎ |
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
… monthly pricing (linode#11475) * Update price on cluster details page to include enterprise * Update test coverage to confirm LKE-E creation details * Added changeset: Update LKE cluster details kube specs for LKE-E monthly pricing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The cluster pricing in the Kube Specs on the LKE details page for an enterprise cluster does not currently match the price that was given when creating a cluster because the LKE-E HA price ($300/month) is not factored in. We need to update this to provide consistent and accurate pricing information for LKE-E clusters.
Changes 🔄
lke-create.spec.ts
with test coverage for thisTarget release date 🗓️
1/14/25
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅