test: [M3-9023] - Add coverage for Kube version upgrades in landing page #11478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-akamai
added
e2e
hana-akamai
changed the title
hana-akamai
requested review from
AzureLatte,
carrillo-erik,
harsh-akamai and
mjac0bs
and removed request for
a team
mjac0bs
approved these changes
Jan 6, 2025
packages/manager/cypress/e2e/core/kubernetes/lke-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
…spec.ts Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Cloud Manager UI test results🎉 473 passing tests on test run #3 ↗︎
|
coliu-akamai
approved these changes
Jan 7, 2025
coliu-akamai
added
Approved
hana-akamai
requested review from
jdamore-linode
and removed request for
AzureLatte
jdamore-linode
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks @hana-akamai! The new tests look good and pass reliably. Thanks for moving those other two tests from lke-update too!
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 30s |
| Commit |
|
| Committer | Hana Xu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
476
|
| View all changes introduced in this branch ↗︎ | |
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
…age (linode#11478) ## Description 📝 Add coverage for checking that there is no upgrade chip when there is no new kube version available and move kube version landing page e2e tests from `lke-update.spec.ts` to `lke-landing-page.spec.ts` ## How to test 🧪 ``` yarn cy:run -s "cypress/e2e/core/kubernetes/lke-landing-page.spec.ts" ``` --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add coverage for checking that there is no upgrade chip when there is no new kube version available and move kube version landing page e2e tests from
lke-update.spec.tstolke-landing-page.spec.tsHow to test 🧪
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅