change: [M3-9074] - Remove properties tab from Gen2 buckets #11491
Conversation
jaalah-akamai
requested review from
AzureLatte,
hana-akamai and
hkhalil-akamai
and removed request for
a team
packages/manager/cypress/e2e/core/objectStorageGen2/bucket-details-gen2.spec.ts
Show resolved
Hide resolved
It will never show for legacy buckets since it's a gen2 feature. It's complicated to mock using MSW. We have an E2E test that ensures it doesn't show though https://github.com/linode/manager/blob/develop/packages/manager/cypress/e2e/core/objectStorage/bucket-details.spec.ts#L33-L54 |
|
Coverage Report: ✅ |
There was a problem hiding this comment.
oh whoops I misunderstood - I'd read the PR title as removing the properties tab for E2/E3 buckets specifically and wasn't sure about E0/E1 buckets
✅ confirmed that with an account with gen2 capabilities, properties tab is hidden for all buckets (E0-E3) - thanks Jaalah!
|
Heads up, I just noticed this on local - Seattle appears twice in the banner:
I don't recall if this was a problem with the banner locally before - it's not on prod + changes here don't look relevant to the banner, but thought I'd mention it just in case it's an issue |
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
|
Here's what I'm seeing: |
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 32m 25s |
| Commit |
|
| Committer | Jaalah Ramos |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
474
|
| View all changes introduced in this branch ↗︎ | |
…1491) * change: [M3-9074] - Remove properties tab from Gen2 buckets * Added changeset: Temporarily remove Properties tab from Gen2 buckets --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Description 📝
The
Propertiestab is a little premature. Although it's correct mostly, it's not 100% for all customers so we need to entirely remove that control for pre-existing buckets until such time as we can expose the correct limit in the API.Note
I'll save this PR for future implementation
Changes 🔄
Propertiestab from Gen2 clustersTarget release date 🗓️
1/14
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅