Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7511, M3-9147] restricted user has disabled inputs on object storage creation #11560

Merged

Conversation

dmcintyr-akamai
Copy link
Contributor

@dmcintyr-akamai dmcintyr-akamai commented Jan 23, 2025

Description 📝

Integration tests for M3-7511 and M3-9147 (avoiding internal linkage on the public repo as a security best practice). When user navigates to object-storage/buckets/create, the label and region inputs are disabled. When user navigates to object-storage/access-keys/create, the label and region inputs as well as the Create button are disabled.

Changes 🔄

  • Added integration tests to packages/manager/cypress/support/intercepts/object-storage.ts.

How to test 🧪

yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-access-keys-gen2.spec.ts,cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts"

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dmcintyr-akamai
Copy link
Contributor Author

this failing test is also failing locally for me in my develop branch, and i did not modify the test in clone-linode.spec.ts or its dependencies.

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmcintyr-akamai, this is a great start! I posted a couple suggestions about how the tests are organized and how we're asserting the error notices, but otherwise this looks good to me and is running reliably.

@jdamore-linode
Copy link
Contributor

this failing test is also failing locally for me in my develop branch, and i did not modify the test in clone-linode.spec.ts or its dependencies.

@dmcintyr-akamai Feel free to disregard that 👍 that and another clone test in linode-config.spec.ts are our flakiest tests. Happy to talk more about those tests offline, but for now feel free to disregard those failures except in cases where you're working on something related to cloning

@dmcintyr-akamai dmcintyr-akamai marked this pull request as ready for review January 28, 2025 20:21
@dmcintyr-akamai dmcintyr-akamai requested review from a team as code owners January 28, 2025 20:21
@dmcintyr-akamai dmcintyr-akamai requested review from jdamore-linode, mjac0bs and harsh-akamai and removed request for a team January 28, 2025 20:21
Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending one change

Copy link

github-actions bot commented Jan 29, 2025

Coverage Report:
Base Coverage: 79.29%
Current Coverage: 79.29%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 476 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing476 Passing2 Skipped92m 25s

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

image

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Jan 29, 2025
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@dmcintyr-akamai dmcintyr-akamai merged commit 92b419c into linode:develop Jan 29, 2025
22 of 23 checks passed
@dmcintyr-akamai dmcintyr-akamai deleted the M3-7511_restricted_user branch January 29, 2025 18:31
Copy link

cypress bot commented Jan 29, 2025

Cloud Manager E2E    Run #7148

Run Properties:  status check passed Passed #7148  •  git commit 92b419c27c: test: [M3-7511, M3-9147] restricted user has disabled inputs on object storage c...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7148
Run duration 31m 14s
Commit git commit 92b419c27c: test: [M3-7511, M3-9147] restricted user has disabled inputs on object storage c...
Committer dmcintyr-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 492
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants