-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-7511, M3-9147] restricted user has disabled inputs on object storage creation #11560
test: [M3-7511, M3-9147] restricted user has disabled inputs on object storage creation #11560
Conversation
this failing test is also failing locally for me in my develop branch, and i did not modify the test in clone-linode.spec.ts or its dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dmcintyr-akamai, this is a great start! I posted a couple suggestions about how the tests are organized and how we're asserting the error notices, but otherwise this looks good to me and is running reliably.
packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts
Outdated
Show resolved
Hide resolved
@dmcintyr-akamai Feel free to disregard that 👍 that and another clone test in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending one change
packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts
Outdated
Show resolved
Hide resolved
Coverage Report: ✅ |
Cloud Manager UI test results🎉 476 passing tests on test run #4 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Cloud Manager E2E Run #7148
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #7148
|
Run duration | 31m 14s |
Commit |
92b419c27c: test: [M3-7511, M3-9147] restricted user has disabled inputs on object storage c...
|
Committer | dmcintyr-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
492
|
View all changes introduced in this branch ↗︎ |
Description 📝
Integration tests for M3-7511 and M3-9147 (avoiding internal linkage on the public repo as a security best practice). When user navigates to object-storage/buckets/create, the label and region inputs are disabled. When user navigates to object-storage/access-keys/create, the label and region inputs as well as the Create button are disabled.
Changes 🔄
How to test 🧪
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅