upcoming: [DI-23083] - Migrated CloudPulseTimeRangeSelect to DateTimeRangePicker #11573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for preset value
…evious preset selected
nikhagra-akamai
changed the title
nikhagra-akamai
requested review from
carrillo-erik and
abailly-akamai
and removed request for
a team
nikhagra-akamai
commented
Jan 28, 2025
| @@ -249,6 +248,9 @@ export const DateTimePicker = ({ | |||
| padding: 0, | |||
| }), | |||
| }, | |||
| field: { | |||
| readOnly: true, | |||
There was a problem hiding this comment.
to avoid user to type inside time select otherwise it'll break the UI
| handleTimeDurationChange(timerDuration); | ||
| handleTimeDurationChange({ | ||
| ...timeDuration, | ||
| end: convertToGmt(timeDuration.end), |
There was a problem hiding this comment.
converting to gmt because api request accepts date in gmt format
|
Coverage Report: ✅ |
venkymano-akamai
approved these changes
Jan 28, 2025
Cloud Manager UI test results🎉 488 passing tests on test run #4 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Migrated Time range select component in ACLP to Date time range picker with presets component.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
10th February 2025
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅