Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-9167] - Image Encryption Information #11579

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Jan 28, 2025

Description 📝

  • Adds a banner on the top of the Images pages that alerts users that Images are now encrypted by default 🔒
    • This is similar to the banner present for Kubernetes Node Encryption
  • Updated the Image Table Row to show if an image is unencrypted 🔓
    • We are doing this because all Images will be encrypted going forward. UX and product decided we only should show if the Image is unencrypted. We don't show anything if the image is encrypted because it is now just default behavior of images.
  • Removed imageServiceGen2 and imageServiceGen2Ga feature flags 🏴 because they have both been enabled for some time now. We can start showing the "Gen2" UI by default now.

Target release date 🗓️

In production by Feb 11th

Preview 📷

Before After
Screenshot 2025-01-28 at 3 41 54 PM Screenshot 2025-01-28 at 3 38 37 PM

How to test 🧪

Prerequisites

  • I recommend testing this with and without the MSW
    • I updated the legacy MSW to mock all possible variations of an Image

Verification steps

  • Legacy Images should show an unencrypted icon 🔓
    • Any image without the distributed-sites capability is considered unencrypted
  • Verify there are no regressions to the Image Capture flow
    • You should be able to capture an image from a Linode in any region, but you should see a warning if the Linode's region does not support Image storage
  • Verify there are no regressions to the Images landing tables
    • Verify both the Custom Images and Recovery Images tables work as expected with no regressions
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the Images Relating to Images label Jan 29, 2025
@bnussman-akamai bnussman-akamai self-assigned this Jan 29, 2025
@bnussman-akamai bnussman-akamai added Work in Progress Blocked Waiting on other work to be done before this and removed Work in Progress labels Jan 29, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 490 passing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing490 Passing2 Skipped96m 29s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Waiting on other work to be done before this Images Relating to Images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants