Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-story: [M3-9098] - Add MSW crud support for firewalls and some IP functionality for Linode Interfaces project #11586

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Jan 29, 2025

Description 📝

  • Add firewalls and firewall device operations to MSW (including seeds)
  • add getting IP addresses to MSW
  • ended up not adding mocks for the below, left some todo comments as needed
    • assigning/sharing IPs - leaving for later if needed, will require additional integration with Linode IPs that seems a bit out of scope for this ticket

Changes 🔄

  • add CRUD for firewalls and firewall devices
  • Add seed for firewalls
  • Add GET for IP addresses
  • update get/delete operations to account for entities stored as [number, Entity] in the mock database

Preview 📷

How to test 🧪

  • Reset MSW
  • Test out firewalls and firewall devices crud mode
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Comment on lines +94 to +95
public_interface: number;
vpc_interface: number;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating this - it'd been a typo in the spec, see [M3-9210] for details

@coliu-akamai coliu-akamai marked this pull request as ready for review January 31, 2025 17:52
@coliu-akamai coliu-akamai requested a review from a team as a code owner January 31, 2025 17:52
@coliu-akamai coliu-akamai requested review from hkhalil-akamai, pmakode-akamai, bnussman-akamai and abailly-akamai and removed request for a team January 31, 2025 17:52
Copy link

github-actions bot commented Jan 31, 2025

Coverage Report:
Base Coverage: 79.28%
Current Coverage: 79.28%

@coliu-akamai coliu-akamai changed the title tech-story: [M3-9098] - Add MSW crud support for firewalls and IPs for Linode Interfaces project tech-story: [M3-9098] - Add MSW crud support for firewalls and some IP functionality for Linode Interfaces project Jan 31, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 488 passing tests on test run #10 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing488 Passing2 Skipped105m 57s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants