Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3-1978 Toast Notifications Styling #4207

Merged
merged 12 commits into from
Dec 11, 2018
Merged

M3-1978 Toast Notifications Styling #4207

merged 12 commits into from
Dec 11, 2018

Conversation

alioso
Copy link
Contributor

@alioso alioso commented Dec 7, 2018 •
edited
Loading

  • added component abstraction
  • added storybook story
  • styled the thing

@alioso alioso self-assigned this Dec 7, 2018
@alioso
Copy link
Contributor Author

alioso commented Dec 7, 2018

Thanks for the typing help @martinmckenna
@nwisnewski we may wanna write some new tests for this

@alioso
Copy link
Contributor Author

alioso commented Dec 7, 2018

I need help with a theme type error

WilkinsKa1
WilkinsKa1 approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@WilkinsKa1 WilkinsKa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

coveralls commented Dec 8, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 32.629% when pulling 6d04042 on alioso:M3-1978 into 8770bb9 on linode:develop.

martinmckenna
martinmckenna suggested changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@martinmckenna martinmckenna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now upgrade notistack and get rid of this line, as the typings for classes should be fixed

iamhosseindhv/notistack#37

@alioso
Copy link
Contributor Author

alioso commented Dec 10, 2018

@martinmckenna all set - nice contribution

Jskobos
Jskobos suggested changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@Jskobos Jskobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just need to remove the sample toasts

src/App.tsx Outdated
setTimeout(() => {
setTimeout(() => {
setTimeout(() => {
this.props.enqueueSnackbar(`Hi Alban! I fixed it! (default)`, { variant: 'default' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably ought to delete these

martinmckenna
martinmckenna reviewed Dec 10, 2018
View reviewed changes
src/App.tsx Outdated
@@ -360,7 +375,7 @@ export class App extends React.Component<CombinedProps, State> {
<Route path="/dashboard" component={Dashboard} />
<Route path="/search" component={SearchLanding} />
<Redirect exact from="/" to="/dashboard" />
\ <Route component={NotFound} />
\ <Route component={NotFound} />
Copy link
Contributor

@martinmckenna martinmckenna Dec 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray slash?

@alioso
Copy link
Contributor Author

alioso commented Dec 10, 2018

@martinmckenna, @Jskobos addressed

@alioso alioso merged commit e4278ec into linode:develop Dec 11, 2018
@alioso alioso deleted the M3-1978 branch October 28, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmckenna martinmckenna martinmckenna approved these changes

@WilkinsKa1 WilkinsKa1 WilkinsKa1 approved these changes

@Jskobos Jskobos Jskobos approved these changes

@rjstires rjstires Awaiting requested review from rjstires

@johnwcallahan johnwcallahan Awaiting requested review from johnwcallahan

@nwisnewski nwisnewski Awaiting requested review from nwisnewski

@rulikrulit rulikrulit Awaiting requested review from rulikrulit

Assignees

@alioso alioso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alioso @coveralls @Jskobos @WilkinsKa1 @martinmckenna @nwisnewski