Fix docker build #6229
Closed
Fix docker build #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some problems with cypress v4.2, so lock it at 4.1. Yarn also seems to require git for some reason, so install it into the container
package.json
Outdated
| @@ -5,6 +5,7 @@ | |||
| "devDependencies": { | |||
| "audit-ci": "^2.4.2", | |||
| "eslint-plugin-cypress": "^2.10.3", | |||
| "cypress": "^4.1", | |||
There was a problem hiding this comment.
The version is in packages/manager/package.json
"cypress": "~4.0.2",
You need to run yarn install:all
There was a problem hiding this comment.
It looks like yarn is trying to install 2 versions of cypress. One version is locked to 4.0.2 in the manager package, but the eslint-plugin-cypress dependency in the root package.json is trying to install the latest version of cypress (4.2) which causes errors downloading the binary. See cypress-io/cypress#4840
|
What is the issue you are encountering? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some problems with cypress v4.2, so lock it at 4.1. Yarn also
seems to require git for some reason, so install it into the container