Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Storybook Dependency Issues #8162

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Fix Storybook Dependency Issues #8162

merged 2 commits into from
Feb 8, 2022

Conversation

bnussman
Copy link
Member

@bnussman bnussman commented Feb 1, 2022 •
edited
Loading

Description

How to test

  • Run yarn clean
  • Run yarn
  • Run yarn up and check for issues and Typescript errors (especially lookout for react-router related errors)
  • Run yarn storybook and check Storybook functionality

@bnussman bnussman self-assigned this Feb 1, 2022
jdamore-linode
jdamore-linode approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Followed the steps in your description and didn't see any issues

tiffwong
tiffwong approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@tiffwong tiffwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a bit and everything looks good to me!

I did notice that the Notification Drawer entry kept causing my browser to crash but that also happened on develop so not sure what's going on with that

@bnussman bnussman merged commit fa7cc25 into linode:develop Feb 8, 2022
@bnussman bnussman mentioned this pull request May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdamore-linode jdamore-linode jdamore-linode approved these changes

@tiffwong tiffwong tiffwong approved these changes

Assignees

@bnussman bnussman

Labels
Storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storybook v6.4 is breaking users using react-router v5
3 participants
@bnussman @tiffwong @jdamore-linode