Remove wait-on package for CVE-2023-25166
#8814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
Dependencies
|
Do we use/need wait-on as a dependency, can we remove it? |
|
@jaalah-akamai I was wondering the same thing, and I verfied with @jdamore-linode we should be able to remove it! |
I didn't know if we needed it for some CLI work, but if we do and we're having trouble bumping the external library - |
bnussman-akamai
changed the title
@sideway/formula to 3.0.1 for CVE-2023-25166wait-on package for CVE-2023-25166
|
@jaalah-akamai Pushed 09e5b8c to remove the dependency and updated the PR description with some context |
jaalah-akamai
approved these changes
Feb 22, 2023
jdamore-linode
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
wait-onpackage to solve CVE-2023-25166 dependabotwait-ondepended on@sideway/formulaand@sideway/formulahas a ReDoS Vulnerabilitywait-onso we can just remove it, resulting in us no longer depending on@sideway/formulawait-onfor e2e pipelines but we now use docker livelesness checksHow to test 🧪