refactor: M3-6195 - Add tss-react and refactor Button to styled API #8821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkhalil-akamai
approved these changes
Feb 24, 2023
| import * as React from 'react'; | ||
| import Reload from 'src/assets/icons/reload.svg'; | ||
| import _Button, { ButtonProps } from 'src/components/core/Button'; |
There was a problem hiding this comment.
It looks like src/components/core/Button isn't used anywhere anymore. Should it be deleted?
There was a problem hiding this comment.
I think it's still used in src/components/PromotionalOfferCard/PromotionalOfferCard.tsx and /src/components/Tile/Tile.tsx, but I agree! It will 100% get removed in the larger migration when we get to those files specifically. Good call out 👍
packages/manager/src/features/Profile/APITokens/RevokeTokenDialog.tsx
Outdated
Show resolved
Hide resolved
carrillo-erik
approved these changes
Feb 24, 2023
dwiley-akamai
pushed a commit
to dwiley-akamai/manager
that referenced
this pull request
Mar 6, 2023
dwiley-akamai
added a commit
that referenced
this pull request
Mar 6, 2023
hana-akamai
added a commit
that referenced
this pull request
Mar 23, 2023
* add user data accordion to linode create * display accordion if image supports cloud-init * update linode create payload * check image for cloud-init * Add validation warning for user data Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * feat: [M3-6149] - Add Cloud Init checkbox to Image Capture/Create flow (#8807) * Add checkbox to Capture Image form * Update request to support cloud_init * Fix controlled component error where checkbox is undefined * Update image validation and types interface for cloud_init * (Debugging an undefined value in createImage request) * Add cloud_init to redux create fn params to include in request * Move checkbox state to ImageCreate so value persists across tabs; code cleanup * Code clean up * Fix comment referencing cloud-init for naming consistency * Update CheckBox tooltip: allow interactivity, minor styling fix * Add final tooltip copy for now * Revert "Merge branch 'develop' into feature/metadata" This reverts commit 8be0c73, reversing changes made to a5e1b25. * feat: [M3-6150] - Add Cloud-init compatible check box to Image Upload flow (#8800) * Add Cloud-init compatible check box * use Checkbox component and reduce space between label and tooltip icon * add new fileds for image create * code cleanup * make cloud_in as optional * Code cleanup * Copy update and PR feedback * code cleanup * Enable interactive to tooltip * feat: [M3 6143] - Add User Data Accordion to Linode Create page (#8811) ## Description 📝 Add User Data accordion to the Linode Create flow so that a user can configure their Linode using cloud-init. ## How to test 🧪 Testing Create via Distribution 1. Point to the dev environment (you might also need additional account setup, reach out for more info) 2. Navigate to the Linode create page http://localhost:3000/linodes/create 3. Select a distribution that supports cloud-init - Arch Linux, Cent OS 7, and Ubuntu 16.04 LTS have been marked as cloud-init compatible for testing purposes 4. If the distribution supports cloud-init, you should see an `Add User Data` accordion - If the distribution doesn't support cloud-init, you should _not_ see the accordion 5. Enter some text (can be anything) into the User Data input field and fill out the rest of the required Linode Create fields 6. Click on Create Linode and observe the POST payload to `/linode/instances`. You should see a metadata field with the user_data object - If you did not enter anything into the User Data input, you should _not_ see any metadata field in the payload. - You can just block the network request to `/linode/instances` and check the payload w/o actually creating another Linode 7. There are no changes to the API response so you will not see a metadata field returned Testing Create via Image - Navigate to the Linode Create Image tab http://localhost:3000/linodes/create?type=Images - Select an image that supports cloud-init - You can create and mark an image as cloud-init compatible in #8807 - Follow steps 4-7 above * Move user data validation warning Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Update user data validation warning UX copy Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Refactor user data validation event handler Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Slighly refactor user data validation Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Pull in tss-react & related changes from #8821 (#8843) * feat: [M3-6146] - Add User Data to Linode Rebuild flow (#8850) * feat: [M3-6145, M3-6191, M3-6233] - Add User Data to Linode Clone and Backup flow (#8859) * Functional flow * add UserDataAccordion.test.tsx * Fix test * Feedback + styling fixes and unit test updates * Add User Data to Linode Clone flow * Add respective user data warning message. * code cleanup * organize UserDataAccordion componet * Code cleanup * refactor: combine two conditional statemets to single one. * Unit test coverage * code cleanup * refactor: code cleanup --------- Co-authored-by: Dajahi Wiley <dwiley@linode.com> * fix: [M3-6254] - Show warning message for only Linode clone and backups (#8888) * fix: [M3-6254] show warning message for only Linode clone and backups flow * PR -feedback * PR Feedback * PR Feedback * Revert "Revert "Merge branch 'develop' into feature/metadata"" This reverts commit 35daaf1. * feat: [M3-6432] - Add Metadata Feature flag (#8910) ## Description 📝 Feature flag Metadata ## How to test 🧪 Toggle the flag on/off with the dev tools and check that Metadata features display/hide in these flows: Image Create - Capture Image - Upload Image Linode Create via - Rebuild - Distribution - Custom Image - Backups - Clone * address feedback --------- Co-authored-by: Hussain Khalil <hkhalil@akamai.com> Co-authored-by: Hussain Khalil <hussain@sanpilot.co> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> Co-authored-by: cpathipa <119517080+cpathipa@users.noreply.github.com> Co-authored-by: Dajahi Wiley <dwiley@linode.com> Co-authored-by: hkhalil-akamai <122488130+hkhalil-akamai@users.noreply.github.com> Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This refactors the
Buttoncomponent to the new sx and styled API. I also added tss-react so that we can begin migrating the older makeStyles API which will give us better type safety and autocomplete than MUI v4, while providing an almost seamless transition in moving away from the deprecated JSS API.Major Changes 🔄
tss-reactButton.test.tsxfor more coverageButtonto usestyledAPIsxprop toHelpIconfor one-off stylingisPropValidto filter out props that are not valid DOM attributespackages/manager/src/stylesfolder for all future sharedkeyframesPreview 📷
How to test 🧪
Buttonstayed the same.yarn test packages/manager/src/components/Buttonand observe unit tests pass.yarn cy:debug