fix: [M3-6254] - Show warning message for only Linode clone and backups

packages/manager/src/features/linodes/LinodesCreate/LinodeCreate.tsx

@@ -35,7 +35,6 @@ import { DefaultProps as ImagesProps } from 'src/containers/images.container';
 import { AppsDocs } from 'src/documentation';
 import EUAgreementCheckbox from 'src/features/Account/Agreements/EUAgreementCheckbox';
 import SMTPRestrictionText from 'src/features/linodes/SMTPRestrictionText';
-import UserDataAccordion from 'src/features/linodes/LinodesCreate/UserDataAccordion/UserDataAccordion';
 import {
   getCommunityStackscripts,
   getMineAndAccountStackScripts,
@@ -60,6 +59,7 @@ import FromBackupsContent from './TabbedContent/FromBackupsContent';
 import FromImageContent from './TabbedContent/FromImageContent';
 import FromLinodeContent from './TabbedContent/FromLinodeContent';
 import FromStackScriptContent from './TabbedContent/FromStackScriptContent';
+import UserDataAccordion from './UserDataAccordion/UserDataAccordion';
 import { renderBackupsDisplaySection } from './TabbedContent/utils';
 import {
   AllFormStateAndHandlers,
@@ -551,11 +551,6 @@ export class LinodeCreate extends React.PureComponent<
     const showUserData =
       imageIsCloudInitCompatible || linodeIsCloudInitCompatible;
 
-    const userDataHeaderWarningMessage =
-      this.props.createType === 'fromBackup'
-        ? 'Existing user data is not available when creating a Linode from a backup.'
-        : 'User data is not cloned.';
-
     return (
       <form className={classes.form}>
         <Grid item className="py0">
@@ -760,11 +755,7 @@ export class LinodeCreate extends React.PureComponent<
             <UserDataAccordion
               userData={this.props.userData}
               onChange={updateUserData}
-              renderHeaderWarningMessage={
-                <Notice warning spacingTop={16} spacingBottom={16}>
-                  {userDataHeaderWarningMessage}
-                </Notice>
-              }
+              createType={this.props.createType}
             />
           ) : null}
           <AddonsPanel

packages/manager/src/features/linodes/LinodesCreate/UserDataAccordion/AccordionHeading.tsx

@@ -1,13 +1,25 @@
 import * as React from 'react';
 import Link from 'src/components/Link';
+import Notice from 'src/components/Notice';
 import { StyledHelpIcon } from './UserDataAccordion.styles';
 
+export const LINODE_CREATE_FROM = {
+  BACKUPS: 'fromBackup',
+  CLONE: 'fromLinode',
+};
+
 interface Props {
-  warningNotice?: JSX.Element;
+  createType?: string | undefined;
 }
 
-const AccordionHeading = (props: Props) => {
-  const { warningNotice } = props;
+const AccordionHeading = ({ createType }: Props) => {
+  const userDataHeaderWarningMessage =
+    createType === LINODE_CREATE_FROM.BACKUPS
+      ? 'Existing user data is not available when creating a Linode from a backup.'
+      : 'User data is not cloned.';
+  const showWarningMessage =
+    createType &&
+    [LINODE_CREATE_FROM.BACKUPS, LINODE_CREATE_FROM.CLONE].includes(createType);
 
   return (
     <>
@@ -22,7 +34,11 @@ const AccordionHeading = (props: Props) => {
         }
         interactive
       />
-      {warningNotice ?? warningNotice}
+      {showWarningMessage ? (
+        <Notice warning spacingTop={16} spacingBottom={16}>
+          {userDataHeaderWarningMessage}
+        </Notice>
+      ) : null}
     </>
   );
 };

packages/manager/src/features/linodes/LinodesCreate/UserDataAccordion/UserDataAccordion.test.tsx

@@ -2,12 +2,14 @@ import * as React from 'react';
 import { fireEvent, screen } from '@testing-library/react';
 import { renderWithTheme } from 'src/utilities/testHelpers';
 import UserDataAccordion from './UserDataAccordion';
+import { LINODE_CREATE_FROM } from './AccordionHeading';
 
 describe('UserDataAccordion', () => {
   const onChange = jest.fn();
   const props = {
     userData: 'test data',
     onChange,
+    createType: '',
   };
   it('should render without errors', () => {
     const { container } = renderWithTheme(<UserDataAccordion {...props} />);
@@ -42,13 +44,12 @@ describe('UserDataAccordion', () => {
 
   it('should display a custom header warning message', () => {
     renderWithTheme(
-      <UserDataAccordion
-        {...props}
-        renderHeaderWarningMessage={<div>Custom warning message</div>}
-      />
+      <UserDataAccordion {...props} createType={LINODE_CREATE_FROM.BACKUPS} />
     );
 
-    const headerWarningMessage = screen.getByText('Custom warning message');
+    const headerWarningMessage = screen.getByText(
+      'Existing user data is not available when creating a Linode from a backup.'
+    );
 
     expect(headerWarningMessage).toBeInTheDocument();
   });

packages/manager/src/features/linodes/LinodesCreate/UserDataAccordion/UserDataAccordion.tsx

@@ -7,20 +7,20 @@ import AccordionHeading from './AccordionHeading';
 import UserDataExplanatory from './UserDataExplanatory';
 
 interface Props {
+  createType?: string;
   userData: string | undefined;
   onChange: (userData: string) => void;
   disabled?: boolean;
-  renderHeaderWarningMessage?: JSX.Element;
   renderNotice?: JSX.Element;
   renderCheckbox?: JSX.Element;
 }
 
 const UserDataAccordion = (props: Props) => {
   const {
+    createType,
     disabled,
     userData,
     onChange,
-    renderHeaderWarningMessage,
     renderNotice,
     renderCheckbox,
   } = props;
@@ -51,7 +51,7 @@ const UserDataAccordion = (props: Props) => {
 
   return (
     <Accordion
-      heading={<AccordionHeading warningNotice={renderHeaderWarningMessage} />}
+      heading={<AccordionHeading createType={createType} />}
       style={{ marginTop: renderNotice && renderCheckbox ? 0 : 24 }} // for now, these props can be taken as an indicator we're in the Rebuild flow.
       headingProps={{
         variant: 'h2',