hotfix: Notification Menu crash due to null value

[hkhalil-akamai]

Description 📝

Fixes a bug that causes the app to crash when opening the Notification Menu.

Major Changes 🔄

• Updates Entity type in api-v4 package to reflect the possibility of a null label
• Adds null check to applyLinking function

How to test 🧪

1. Verify opening the Events Menu does not cause a crash when a user has an entity event with a null label (e.g., entity_transfer)

[mjac0bs]

Confirmed that the notification menu and events landing pages no longer result in a crash with an entity_transfer event. Nice catch here. Can we also submit a request to get the API docs updated to show this field as nullable?

[abailly-akamai]

Thanks! I'll make a ticket to refactor this file.

1. It's another case of crashing the browser where we could error a bit more gracefully (try/catch)
2. We've got 100s of instances of entity.label handled in various ways which we should try to consolidate

[cypress]

5 failed tests on run #4577 ↗︎

5

162

3

0

0

Details:

Check all instances of entity.label in eventMesssageGenerator
Project: Cloud Manager E2E	Commit: a676e3851a
Status: Failed	Duration: 20:14 💡
Started: Jun 28, 2023 12:23 AM	Ended: Jun 28, 2023 12:44 AM

  firewalls/update-firewall.spec.ts • 1 failed test

View Output Video

Test		Artifacts
update firewall > updates a firewall's linodes and rules		Output Screenshots Video

  images/create-linode-from-image.spec.ts • 2 failed tests

View Output Video

Test		Artifacts
create linode from image, mocked data > creates linode from image on images tab		Output Screenshots Video
create linode from image, mocked data > creates linode from preselected image on images tab		Output Screenshots Video

  firewalls/create-firewall.spec.ts • 1 failed test

View Output Video

Test		Artifacts
create firewall > creates a firewall assigned to a linode		Output Screenshots Video

  images/smoke-create-image.spec.ts • 1 failed test

View Output Video

Test		Artifacts
create image > captures image from Linode and mocks create image		Output Screenshots Video

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}