feat: [M3-7058] - Add AGLB Create Page - Stepper component #9520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
approved these changes
Aug 21, 2023
bnussman-akamai
added
Add'tl Approval Needed
packages/manager/src/components/VerticalLinearStepper/VerticalLinearStepper.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/VerticalLinearStepper/VerticalLinearStepper.styles.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/VerticalLinearStepper/VerticalLinearStepper.styles.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/VerticalLinearStepper/VerticalLinearStepper.styles.ts
Outdated
Show resolved
Hide resolved
| ]; | ||
|
|
||
| test('renders all steps and navigates', () => { | ||
| renderWithTheme(<VerticalLinearStepper steps={steps} />); |
There was a problem hiding this comment.
Not sure if it's needed for a POC pr, but commenting here in case you planned to add more tests
There was a problem hiding this comment.
Technically, it may not be required for the POC. However, I've added it as a placeholder and left a comment for future enhancements, should we decide to add more tests as we move forward.
…LinearStepper.styles.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
…LinearStepper.styles.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
…LinearStepper.styles.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
|
Thank you @coliu-akamai! good catch on console warnings. Addressed above feedback, PR is ready for re-review. |
bnussman-akamai
added
Approved
cpathipa
changed the title
cpathipa
changed the title
This was referenced Sep 5, 2023
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
* feat: stepper component POC * VerticalLinearStepper unit tests * Stepper component story * Code cleanup * Added changeset: AGLB - Stepper component * Update packages/manager/src/components/VerticalLinearStepper/VerticalLinearStepper.styles.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> * Update packages/manager/src/components/VerticalLinearStepper/VerticalLinearStepper.styles.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> * Update packages/manager/src/components/VerticalLinearStepper/VerticalLinearStepper.styles.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com> * Fix console warnings in storybook * Update VerticalLinearStepper.test.tsx * Update unit tests * Update VerticalLinearStepper.test.tsx * Update pr-9520-upcoming-features-1692378386106.md --------- Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Stepper component POC for AGLB
Preview 📷
StepperComponent.mov
Dark Mode
