fix: New LKE clusters get stuck provisioning when HA price is undefined #9558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluster when no HA price is defined
|
I don't think we need to worry about fitting this into the 1.100 release since this issue does not impact |
bnussman-akamai
approved these changes
Aug 17, 2023
bnussman-akamai
added
Add'tl Approval Needed
|
It took about 12 minutes to create a HA cluster with 3 shared 2 GB instances |
TylerWJ
approved these changes
Aug 22, 2023
bnussman-akamai
added
Approved
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
…ed (linode#9558) * Pass `false` for `control_plane.high_availability` when creating LKE cluster when no HA price is defined * Added changeset: Fix stuck LKE node pools when HA Control Plane is unavailable --------- Co-authored-by: mjac0bs <mjacobs@akamai.com>
abailly-akamai
pushed a commit
that referenced
this pull request
Sep 7, 2023
…ed (#9558) * Pass `false` for `control_plane.high_availability` when creating LKE cluster when no HA price is defined * Added changeset: Fix stuck LKE node pools when HA Control Plane is unavailable --------- Co-authored-by: mjac0bs <mjacobs@akamai.com>
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This fixes an issue where creating an LKE Cluster in environments where
REACT_APP_LKE_HIGH_AVAILABILITY_PRICEis undefined results in a cluster with nodes stuck in "provisioning" state, and the only way to get them un-stuck is to enable high availability, which is irreversible. The issue is fixed by passingfalseforcontrol_plane.high_availabilityin cases where the environment variable is undefined.I don't think this is strictly a Cloud Manager issue because the API does not respond with a
400, and the API docs state thatcontrol_plane.high_availabilityis treated asfalseby default. Regardless, explicitly passingfalseresults in clusters that provision successfully, and leaving it absent seems to result in clusters that get stuck.Major Changes 🔄
falsetocontrol_plane.high_availabilityexplicitly when the HA control plane prompt is not presentHow to test 🧪
To Reproduce the Issue
develop, remove theREACT_APP_LKE_HIGH_AVAILABILITY_PRICEenvironment variable from your.envfile if necessary, and build Cloud ManagerTo Verify These Changes
REACT_APP_LKE_HIGH_AVAILABILITY_PRICEenvironment variable from your.envfile if necessary, and build Cloud ManagerREACT_APP_LKE_HIGH_AVAILABILITY_PRICEenvironment variable, create an LKE cluster with HA enabled and an LKE cluster with HA disabled, and confirm that both clusters finish provisioning after a few minutes