Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore Longview styling to what it used to be #9619

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

coliu-akamai
Copy link
Contributor

Description 📝

Major Changes 🔄

  • add spacing to any grids with the container prop that didn't have spacing specified
current prod what prod should look like
image image

How to test 🧪

  1. git checkout 84f1083 to see how the styling previously looked, and compare this branch with the checked out commit

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing those! looks good 👍

packages/manager/.changeset/pr-9619-fixed-1693518126299.md Outdated Show resolved Hide resolved
@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 31, 2023
Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 1, 2023
@coliu-akamai coliu-akamai merged commit d71430d into linode:develop Sep 1, 2023
@tyler-akamai
Copy link
Contributor

Good catch!

bnussman-akamai pushed a commit to bnussman-akamai/manager that referenced this pull request Sep 5, 2023
* add spacing back

* add changeset

* Update packages/manager/.changeset/pr-9619-fixed-1693518126299.md

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>

---------

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
tyler-akamai pushed a commit to bnussman-akamai/manager that referenced this pull request Sep 5, 2023
* add spacing back

* add changeset

* Update packages/manager/.changeset/pr-9619-fixed-1693518126299.md

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>

---------

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
* add spacing back

* add changeset

* Update packages/manager/.changeset/pr-9619-fixed-1693518126299.md

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>

---------

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
abailly-akamai added a commit that referenced this pull request Sep 7, 2023
* add spacing back

* add changeset

* Update packages/manager/.changeset/pr-9619-fixed-1693518126299.md

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>

---------

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
@coliu-akamai coliu-akamai deleted the fix-longview-styling branch September 26, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants