change: [poc] - Better subnet validation behavior on VPCCreate page #9659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
requested review from
dwiley-akamai,
hana-akamai and
jaalah-akamai
coliu-akamai
changed the title
dwiley-akamai
approved these changes
Sep 13, 2023
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
|
@dwiley-akamai I've also seen subnet errors for having 2+ subnets with the same label or same IP range (these come in as
|
coliu-akamai
added
Add'tl Approval Needed
| visualToAPISubnetMapping: {} | ||
| ) => { | ||
| const combinedSubnets: SubnetFieldState[] = []; | ||
| for (let i = 0; i < values.subnets.length; i++) { |
There was a problem hiding this comment.
Nit: I think we can simplify this by using a .map instead. That way we don't have to push the values to an array. We can also destructure the errors in the if block const errorData = errors[apiSubnetIdx];
jaalah-akamai
approved these changes
Sep 13, 2023
coliu-akamai
added
Approved
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Previously when working on the VPCCreate page, I'd made two validation versions:
In the current reason, errors for specific subnets might sometimes appear as general subnet errors, because of how subnet validation happened... Wasn't the biggest fan of that behavior, so I looked into this some more. That's where this PR comes in -- it uses the CreateVPCSchema validation and processes any subnet specific errors returned by the API, while still having the same UI behavior of the current version.
Major Changes 🔄
Preview 📷
How to test 🧪
yarn test formikErrorUtils.test.ts