fix: [M3-7117] - Fix style consistency issues with NodeBalancer create flow panels #9673
Conversation
mjac0bs
changed the title
|
This is just a UX observation and not related to your work on this PR. It does appear like we have a lot of empty space to the right of the red line in the below. We can probably utilize that extra space more efficiently and the helper text below Proxy Protocol and other components would not look so smushed together. |
abailly-akamai
force-pushed
the
fix-M3-7117
branch
from
cda3b5c to
de51487
Compare
|
@carrillo-erik fair enough! i adjusted things slightly
|
| @@ -225,8 +225,8 @@ export const NodeBalancerConfigPanel = ( | |||
|
|
|||
| {protocol === 'https' && ( | |||
| <Grid xs={12}> | |||
| <Grid container spacing={2}> | |||
| <Grid xs={12}> | |||
| <Grid columns={12} container spacing={2}> | |||
There was a problem hiding this comment.
@jaalah wanted to grab your attention about this particular issue with the conditional rendering of an instance of <Grid container /> (Unstable_Grid2) which does not seem to load the CSS grid column variables unless the component is initially rendered on page load.
https://stackoverflow.com/questions/75546810/mui-system-grid-columns-css-var-is-undefined
There was a problem hiding this comment.
@abailly-akamai A nested container should be direct child of another grid container, unless you explicitly want the grid container to be a new root container with it's own variable scope. So what you want here is to remove <Grid xs={12}> and just do <Grid columns={12} container spacing={2} xs={12}>
There was a problem hiding this comment.
Is that the problem? why would I need to redefine the columns count?
There was a problem hiding this comment.
In case you wanted to change the columns count for whatever reason: https://mui.com/material-ui/react-grid2/#nested-grid. If you wanted a different size grid
There was a problem hiding this comment.
right right, it's just not needed. the default is 12. lemme make quick changes
|
Wow, what a form this is. Thanks for unsquishing the key and cert fields. I found a couple of other weird things if you'd like to address them in this PR, but don't want to hold this up and prevent it from getting it into the release because your other changes are definitely an improvement upon what's in prod.
|
|
@mjac0bs will fix those in a new PR |
|
@mjac0bs @jaalah-akamai actually addressed all comments. good to go! |
There was a problem hiding this comment.
Great, thanks!
I'm going to make a follow up ticket (M3-7142) for some copy writing here. Just noticed our sentence says "Roundrobin." which is not entirely helpful, but I'm not sure what actually goes here/how long it's been like that. And whether we want to continue to display the description of every algorithm type, or just the one that is currently selected.
Description 📝
This PR fixes the alignment of the NB create flow panels and accordions. This one has bothered me for a while!
Preview 📷
How to test 🧪
Protocolin Configurations &Typein Active Health Checks etc)