fix: [M3-7191] - Missing primary and secondary action button labels in Delete SSH Key dialog and Clone Domain drawer #9726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lone Domain drawer
mjac0bs
changed the title
mjac0bs
commented
Sep 27, 2023
| @@ -26,6 +26,7 @@ const DeleteSSHKeyDialog = ({ id, label, onClose, open }: Props) => { | |||
| <ActionsPanel | |||
| primaryButtonProps={{ | |||
| 'data-testid': 'confirm-delete', | |||
| label: 'Delete', | |||
There was a problem hiding this comment.
This was the actual fix for the bug reported in the ticket.
| @@ -10,7 +10,7 @@ import { Box, BoxProps } from '../Box'; | |||
| interface ActionButtonsProps extends ButtonProps { | |||
| 'data-node-idx'?: number; | |||
| 'data-testid'?: string; | |||
| label?: string; | |||
| label: string; | |||
There was a problem hiding this comment.
This prop was optional, which is what allowed the bug to exist in the first place. We shouldn't allow unlabeled buttons.
When I made label required, it led to an error at the one other place in the app where an action button was missing a label: the Clone Domain Drawer and its secondary button, Cancel. This was another bug, with an existing but unlabeled and therefore invisible-seeming button.
mjac0bs
requested review from
abailly-akamai and
tyler-akamai
and removed request for
a team
|
Tested the following:
|
tyler-akamai
approved these changes
Sep 27, 2023
abailly-akamai
approved these changes
Sep 27, 2023
| @@ -10,7 +10,7 @@ import { Box, BoxProps } from '../Box'; | |||
| interface ActionButtonsProps extends ButtonProps { | |||
| 'data-node-idx'?: number; | |||
| 'data-testid'?: string; | |||
| label?: string; | |||
| label: string; | |||
| expect(props.onClose).toBeCalled(); | ||
| }); | ||
| }); | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR aimed to fix a bug with a missing button label in the Delete SSH Key dialog and ended up fixing another related bug in the Clone Domain drawer.
Major Changes 🔄
Deletelabel to the primary action button in the SSH key delete dialoglabela required, not an optional, prop forActionButtonPropsCancelbutton appears invisible in the Clone Domain drawer because it was also missing a labelDeleteSSHKeyDialogcomponent and updates unit test forActionPanelcomponent.Preview 📷
Screen.Recording.2023-09-27.at.7.39.33.AM.mov
Screen.Recording.2023-09-27.at.7.40.11.AM.mov
How to test 🧪
Add an SSH Key.Create Domain.yarn devDelete.Cancelbutton and click it to close the drawer, but it is otherwise invisible.Deletebutton is labeled accordingly.Cancelbutton is visible and clicking it closes the drawer.