-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: [M3-6219] - Clean up Cypress Firewall tests #9807
Merged
jdamore-linode
merged 11 commits into
linode:develop
from
jdamore-linode:M3-6219-firewall-test-cleanup
Oct 25, 2023
Merged
tests: [M3-6219] - Clean up Cypress Firewall tests #9807
jdamore-linode
merged 11 commits into
linode:develop
from
jdamore-linode:M3-6219-firewall-test-cleanup
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
hana-akamai and
tyler-akamai
and removed request for
a team
October 17, 2023 19:25
hana-akamai
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that E2E tests passed locally ✅
hana-akamai
added
Add'tl Approval Needed
Waiting on another approval!
and removed
Ready for Review
labels
Oct 17, 2023
tyler-akamai
approved these changes
Oct 18, 2023
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Oct 18, 2023
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This cleans up the Cypress Firewall tests by implementing newer testing patterns.
Changes 🔄
cy.intercept
, replacing them with calls intercept and mocking utilsui
helpers where applicable, reduce number of calls tocy.get()
How to test 🧪
Prerequisites
Test Command
yarn cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts,cypress/e2e/core/firewalls/delete-firewall.spec.ts,cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts,cypress/e2e/core/firewalls/update-firewall.spec.ts"
As an Author I have considered 🤔
Check all that apply