-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7104] - Images create > upload image > reduce space above and below Linode CLI help text #9812
fix: [M3-7104] - Images create > upload image > reduce space above and below Linode CLI help text #9812
Conversation
…nd below Linode CLI help text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! When did this get into prod? 😅 Confirmed that the spacing looks normal now, checked all screen sizes. Left a minor suggestion about rewording the changeset.
Just had a question after looking at the internal ticket: Can we clarify with UX whether this ticket is asking for other copy updates to the Upload Image form? The copy on the proposed change doesn't match prod. I'm a bit concerned by that big block of text in the mock, though. That's in a tooltip now. The mock may just be outdated? Or are we intended to replace the tooltip and warning styling? |
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
I assumed the mock was outdated since they are still using the Linode logo in the top left, but let me confirm! |
Oh, hah, yeah, that's very outdated! This ticket was created in Sept of this year, which is what confused me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, nice fix!
I had a feeling we would be caught by this one day (the way MUI does number
* theme.spacing
)
Description 📝
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply