-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7289] – Payload refinements in "Assign Linodes" flow #9845
change: [M3-7289] – Payload refinements in "Assign Linodes" flow #9845
Conversation
…onfig previously only had an implicit public interface in Assign Linodes flow
@@ -943,7 +943,7 @@ export class LinodeCreate extends React.PureComponent< | |||
]; | |||
} | |||
|
|||
const defaultPublicInterface: InterfacePayload = { | |||
export const defaultPublicInterface: InterfacePayload = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I briefly considered moving this to src/constants.ts
, but it felt out of place there and I didn't see a better spot so I just exported it from here for now.
@hana-linode I think we just take care of that with |
packages/manager/src/features/VPCs/VPCDetail/SubnetAssignLinodesDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/VPCs/VPCDetail/SubnetAssignLinodesDrawer.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approving after confirmation of a few questions. ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Dajahi!
- confirmed two network requests sent in the first case described
- confirmed one network request sent if linode already had vlan assigned to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Two requests to /interfaces
with expected payload when no VLAN or VPC on initial create:
Screen.Recording.2023-10-30.at.2.12.41.PM.mov
✅ One request to /interfaces
with expected payload when there's a VLAN on initial create:
Screen.Recording.2023-10-30.at.2.13.57.PM.mov
packages/manager/cypress/e2e/core/databases/update-database.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Two requests to /interfaces, the first for adding an explicit public interface, and the second for the VPC interface (confirm it has primary: true and nat_1_1: 'any')
✅ One request to /interfaces when there’s already a VLAN
Description 📝
Currently, VPC interfaces added via the Assign Linodes flow are not marked as
primary
and are not 1:1 NAT'ed. This results in a sub-optimal and possibly non-functional configuration.Changes 🔄
primary: true
andnat_1_1: 'any'
to the interface payloadinterfaces
array comes back from the API as empty), explicitly add a public interface in eth0How to test 🧪
Prerequisites
dev
environmentVerification steps
With the Network tab of Dev Tools open...
/interfaces
, the first for adding an explicit public interface, and the second for the VPC interface (confirm it hasprimary: true
andnat_1_1: 'any'
)For other possible permutations (e.g., a linode with a VLAN already assigned), confirm that going through the "Assign Linodes" flow results in a VPC interface being added with
primary: true
andnat_1_1: 'any'
in the payload. No explicit public interfaces should be in the payload outside of the scenario detailed above.As an Author I have considered 🤔
Check all that apply